Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to Identify the links under "In this article" as links: A11y_VisualStudioCodeServices_Uninstall Visual Studio Code_In this article_Info and Relationships. #7415

Open
prabhudevu opened this issue Jun 26, 2024 · 6 comments
Assignees
Labels
accessibility under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@prabhudevu
Copy link

prabhudevu commented Jun 26, 2024

"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver".

GitHub Tags:

#A11yTCS; #A11ySev3; #A11yMAS; #DesktopWeb; #ChromiumEdge; #BM_VisualStudioCodeServices_Web_July2024; #Visual Studio Code Services; #Win11; #FTP; #Desktopweb; #WCAG1.3.1; #Element:Link

Environment Details: 

Application Name:  Visual Studio Code Services
URL: https://code.visualstudio.com/docs/setup/uninstall?dark-plus-v2#_windows
Microsoft Edge version 126.0.2592.68 (Official build) (64-bit)

Repro steps:

  1. Launch the application URL: https://code.visualstudio.com/docs/setup/uninstall?dark-plus-v2#_windows and press ENTER.
  2. "Uninstall Visual Studio Code" screen gets opened.
  3. TAB to Links under "In this article"
  4. Observe that not able to Identify the links under "In this article" as links.

Actual:

Not able to Identify the links under "In this article" as links.

Note: Issue is repro with below URLs as well
https://code.visualstudio.com/docs/setup/uninstall?dark-plus-v2
https://code.visualstudio.com/docs/supporting/faq?dark-plus-v2
https://code.visualstudio.com/docs?dark-plus-v2
https://code.visualstudio.com/download?dark-plus-v2
https://code.visualstudio.com/insiders/?dark-plus-v2
https://code.visualstudio.com/?dark-plus-v2
https://code.visualstudio.com/docs/python/editing?dark-plus-v2
https://code.visualstudio.com/docs/python/jupyter-support-py?dark-plus-v2
https://code.visualstudio.com/docs/python/linting?dark-plus-v2
https://code.visualstudio.com/docs/remote/remote-overview?dark-plus-v2
https://code.visualstudio.com/docs/remote/troubleshooting?dark-plus-v2
https://code.visualstudio.com/docs/remote/wsl?dark-plus-v2
https://code.visualstudio.com/docs/?dv=win64user&dark-plus-v2
https://code.visualstudio.com/docs/editor/command-line?dark-plus-v2
https://code.visualstudio.com/docs/getstarted/introvideos?dark-plus-v2
https://code.visualstudio.com/docs/getstarted/keybindings?dark-plus-v2
https://code.visualstudio.com/docs/getstarted/locales?dark-plus-v2
https://code.visualstudio.com/docs/java/java-debugging?dark-plus-v2
https://code.visualstudio.com/docs/languages/csharp?dark-plus-v2
https://code.visualstudio.com/docs/python/debugging?dark-plus-v2

Expected

Links under "In this article" should be defined in a way for us to understand they are links.

User Impact

Users will not be able to know that the items under in this article" as links.

Attachment

1linkey

1  Note artile

Screenshot 2024-06-26 183900

@daviddossett
Copy link
Contributor

The links in the table of contents and "In this article" section are technically links, but they aren't links that need to be differentiated from paragraph text. I don't think it makes sense to decorate these in the same way we've done for the inline links with the grey underline. It would be a total mess of underlines.

I suggest we don't make any changes here yet given that this isn't new behavior for the v2 website design.

@12-shweta
Copy link

#rev:shwarh

@12-shweta
Copy link

#A11yPreview;

@rzhao271 rzhao271 self-assigned this Jul 11, 2024
@rzhao271 rzhao271 added this to the July 2024 milestone Jul 11, 2024
@rzhao271 rzhao271 added accessibility bug Issue identified by VS Code Team member as probable bug labels Jul 11, 2024
@rzhao271 rzhao271 modified the milestones: July 2024, August 2024 Jul 25, 2024
@rzhao271 rzhao271 modified the milestones: August 2024, September 2024 Aug 26, 2024
@rzhao271
Copy link
Contributor

rzhao271 commented Sep 5, 2024

Hi @prabhudevu, considering that the left sidebar doesn't have underlined links, is there a way we could format the right sidebar instead to not require underlined links?

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Sep 5, 2024
@12-shweta
Copy link

12-shweta commented Sep 9, 2024

@rzhao271 in the below way also we can differentiate check the right pane, please refer https://www.w3.org/WAI/ARIA/apg/example-index/#examples_by_role_label
image

@rzhao271 rzhao271 added under-discussion Issue is under discussion for relevance, priority, approach and removed info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug labels Sep 20, 2024
@rzhao271 rzhao271 modified the milestones: September 2024, October 2024 Sep 21, 2024
@rzhao271
Copy link
Contributor

I continue to agree with David and do not see a reason to format the right links differently by default. The right nav links react to being hovered or focused, and are located under a caption that suggests they are nav links as well.

However, I notice that hovering the left or right links does not result in an underline under the hovered link, and I believe adding an underline to the hovered link would improve the UX of the site.

@rzhao271 rzhao271 modified the milestones: October 2024, November 2024 Oct 21, 2024
@rzhao271 rzhao271 modified the milestones: November 2024, January 2025 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants