Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint about search.useRipgrep? #1677

Closed
imba-tjd opened this issue Jun 12, 2018 · 3 comments
Closed

Add a hint about search.useRipgrep? #1677

imba-tjd opened this issue Jun 12, 2018 · 3 comments

Comments

@imba-tjd
Copy link
Contributor

Hi. In
https://github.com/Microsoft/vscode-docs/blob/master/docs/editor/codebasics.md#search-across-files

VS Code does support regular expression searches, however, backreferences, lookaround, and multiline matches are not supported. This is because VS Code depends on the search tool ripgrep, which, while extremely fast, doesn't support these advanced regex features.

But I see VSC has a search.useRipgrep option. If it is set to false, VSC seems support those advance search options. Shall we add a hint about it?

Besides, there are a search.useRipgrep option and a searchrg.enable option, which make me confused...
Thanks.

@roblourens
Copy link
Member

I keep trying to remove the old non-ripgrep search. I'm also working on allowing extensions to contribute their own search provider: microsoft/vscode#47058. With that API, someone can implement an extension for search that supports all the advanced regex features.

Thanks for the suggestion but I don't want to encourage anyone else to depend on search.useRipgrep for now. And searchrg.enable is temporary for switching between the builtin search and the "experimental" search that uses the SearchProvider api.

@AlexFiliakov
Copy link

search.useRipgrep doesn't work anymore

"search.useRipgrep": false; // doesn't give lookahead

The advice in microsoft/vscode#24626 is outdated.

@roblourens
Copy link
Member

It works for me? But, don't count on search.useRipgrep, it will probably be removed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants