Removing custom allocator in the desktop app #1771
deepak1556
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In the upcoming release
v1.94
of VSCode, we have removed the custom alloctor that was added inv1.78
to the desktop application extension host to act as a bridge to support V8 sandbox incompatible Node.js native addons built against the Electron runtime. You can refer to this tracking issue for additional context. We have ensured that the top 5000 extensions are unaffected by this change. If your extension or a dependency of your extension is affected, here are some suggestions:napi_no_external_buffers_allowed
will be returned when using external array buffers. In which case, you can switch to use the copy version of the API napi_create_buffer_copy.We have also added telemetry points to identify extensions and native addons that could be affected, so we can proactively reach out to extension authors and offer help were possible. If your extension is effected, and none of the above suggestions work for you please comment here and we will gladly help.
Beta Was this translation helpful? Give feedback.
All reactions