macFrameworkPath isn't working? #3323

sean-mcmanus · 2019-03-20T01:55:50Z

Unfortunately this feature seems to not work on my side,

As you can see i tried different things, put the root folder or frameworks/headers directories directly.
The result is always the same.

If i switch "fuzzy" mode on & off the result is the same (well in fuzzy mode it's underlined in green with a message telling to update includePath). Did I miss something ?

OSX 10.14.3
VSCode 1.32.3
CPP Tools 0.21.0

Originally posted by @jbltx in #970 (comment)

jbltx · 2019-03-21T15:04:15Z

As I said in #970 (comment), it seems there's a difference between writing manually the Headers path in the configuration file, and clicking the suggestion given by the tool in any #include. Only the suggestion clear the errors.
To more, I think the suggestion shouldn't be the real Headers path, but a Framework one.

I can take a look at the code this evening if there's no assignee yet.

sean-mcmanus · 2019-03-21T16:53:33Z

The code action is implemented in the addToIncludePathCommand method in our open source (https://github.com/Microsoft/vscode-cpptools/blob/master/Extension/src/LanguageServer/configurations.ts), but it basically just writes to the c_cpp_properties.json, so I don't know why the behavior would be different.

julee · 2020-03-24T09:49:35Z

Any news? It's Troublesome

sean-mcmanus · 2020-03-25T21:43:32Z

@julee What issue are you hitting? I don't think we found a repro for this issue. Can you provide more repro info?

julee · 2020-03-26T02:15:32Z

@julee What issue are you hitting? I don't think we found a repro for this issue. Can you provide more repro info?

Project:
vs_sample.zip

you may edit the .vscode/setting.json , change Qt5_DIR to the correct path:

{
    "cmake.configureArgs": [
        "-DQt5_DIR=/Users/julee/Qt5.10.1/5.10.1/clang_64/lib/cmake/Qt5"
    ],
    "C_Cpp.default.configurationProvider": "vector-of-bool.cmake-tools"
}

After cmake: configure the project, Qt head files cannot find by vscode, though all include path are detected.

C/C++ Log Diagnostics output:

-------- Diagnostics - 3/26/2020, 10:02:58 AM
Version: 0.26.3
Current Configuration:
{
    "name": "Mac",
    "includePath": [
        "${workspaceFolder}/**"
    ],
    "defines": [],
    "macFrameworkPath": [
        "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks"
    ],
    "compilerPath": "/usr/bin/clang",
    "knownCompilers": [
        {
            "path": "/usr/bin/clang",
            "isC": true
        },
        {
            "path": "/usr/bin/clang++",
            "isC": false
        },
        {
            "path": "/usr/bin/gcc",
            "isC": true
        },
        {
            "path": "/usr/bin/g++",
            "isC": false
        },
        {
            "path": "/usr/bin/cpp",
            "isC": false
        },
        {
            "path": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang",
            "isC": true
        },
        {
            "path": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++",
            "isC": false
        },
        {
            "path": "/usr/bin/clang",
            "isC": false
        }
    ],
    "cStandard": "c11",
    "cppStandard": "c++17",
    "intelliSenseMode": "clang-x64",
    "compilerArgs": [],
    "configurationProvider": "vector-of-bool.cmake-tools",
    "browse": {
        "path": [
            "${workspaceFolder}/**"
        ],
        "limitSymbolsToIncludedHeaders": true
    }
}
Translation Unit Mappings:
[ /Volumes/SSD/code/issue_test/vs_sample/main.cc ]:
    /Volumes/SSD/code/issue_test/vs_sample/main.cc
Translation Unit Configurations:
[ /Volumes/SSD/code/issue_test/vs_sample/main.cc ]:
    Process ID: 73493
    Memory Usage: 7 MB
    Compiler Path: /usr/bin/clang++
    Includes:
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtWidgets.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtWidgets.framework/Versions/5/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtGui.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtGui.framework/Versions/5/Headers
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtCore.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtCore.framework/Versions/5/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/mkspecs/macx-clang
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/include
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include
    Frameworks:
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks
    Defines:
        QT_CORE_LIB
        QT_GUI_LIB
        QT_WIDGETS_LIB
    Standard Version: c++11
    IntelliSense Mode: clang-x64
    Other Flags:
        --clang
        --clang_version=110000
Total Memory Usage: 7 MB

-------- Diagnostics - 3/26/2020, 10:06:58 AM
Version: 0.26.3
Current Configuration:
{
    "name": "Mac",
    "includePath": [
        "${workspaceFolder}/**"
    ],
    "defines": [],
    "macFrameworkPath": [
        "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks"
    ],
    "compilerPath": "/usr/bin/clang",
    "knownCompilers": [
        {
            "path": "/usr/bin/clang",
            "isC": true
        },
        {
            "path": "/usr/bin/clang++",
            "isC": false
        },
        {
            "path": "/usr/bin/gcc",
            "isC": true
        },
        {
            "path": "/usr/bin/g++",
            "isC": false
        },
        {
            "path": "/usr/bin/cpp",
            "isC": false
        },
        {
            "path": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang",
            "isC": true
        },
        {
            "path": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++",
            "isC": false
        },
        {
            "path": "/usr/bin/clang",
            "isC": false
        }
    ],
    "cStandard": "c11",
    "cppStandard": "c++17",
    "intelliSenseMode": "clang-x64",
    "compilerArgs": [],
    "configurationProvider": "vector-of-bool.cmake-tools",
    "browse": {
        "path": [
            "${workspaceFolder}/**"
        ],
        "limitSymbolsToIncludedHeaders": true
    }
}
Translation Unit Mappings:
[ /Volumes/SSD/code/issue_test/vs_sample/main.cc ]:
    /Volumes/SSD/code/issue_test/vs_sample/main.cc
Translation Unit Configurations:
[ /Volumes/SSD/code/issue_test/vs_sample/main.cc ]:
    Process ID: 73587
    Memory Usage: 7 MB
    Compiler Path: /usr/bin/clang++
    Includes:
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtWidgets.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtWidgets.framework/Versions/5/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtGui.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtGui.framework/Versions/5/Headers
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtCore.framework
        /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtCore.framework/Versions/5/Headers
        /Users/julee/Qt5.10.1/5.10.1/clang_64/mkspecs/macx-clang
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/include
        /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include
    Frameworks:
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks
    Defines:
        QT_CORE_LIB
        QT_GUI_LIB
        QT_WIDGETS_LIB
    Standard Version: c++11
    IntelliSense Mode: clang-x64
    Other Flags:
        --clang
        --clang_version=110000
Total Memory Usage: 7 MB

julee · 2020-04-15T04:22:25Z

@sean-mcmanus Any news for this issue?

sean-mcmanus · 2020-04-15T18:21:01Z

I'm not sure if anyone investigated this yet. What is the exact error message, i.e. which header is missing? QtGui/QGuiApplication or a dependency of that ? Where is the file located? At one of the paths in the "Includes" in your logs?

julee · 2020-04-16T01:53:05Z

I'm not sure if anyone investigated this yet. What is the exact error message, i.e. which header is missing? QtGui/QGuiApplication or a dependency of that ? Where is the file located? At one of the paths in the "Includes" in your logs?

QtGui/QGuiApplication not found. it's locate at: /Users/julee/Qt5.10.1/5.10.1/clang_64/lib/QtGui.framework/Versions/5/Headers

julee · 2020-04-16T01:54:46Z

@sean-mcmanus You can try that demo project with macOS, just edit the .vscode/setting.json ,set Qt5_DIR to correct path, you can find the bug

bobbrow · 2020-04-16T04:56:56Z

I think the problem is that /Users/julee/Qt5.10.1/5.10.1/clang_64/lib is not being added as a framework path. This looks like a bug with CMake Tools.

bobbrow · 2020-04-16T04:58:54Z

You could write it as #include <QGuiApplication> to make IntelliSense work, but I don't know if that will compile for you.

julee · 2020-04-16T06:40:50Z

You could write it as #include <QGuiApplication> to make IntelliSense work, but I don't know if that will compile for you.

use #include <QGuiApplication> Wont' work, it says:
can't open "QtGui/qtguiglobal.h" (dependency of "QGuiApplication").

julee · 2020-04-16T06:43:15Z

I think the problem is that /Users/julee/Qt5.10.1/5.10.1/clang_64/lib is not being added as a framework path. This looks like a bug with CMake Tools.

Yes, you are right! It's a bug with CMake Tools.
I try remove "configurationProvider": "vector-of-bool.cmake-tools", and add: "compileCommands": "${workspaceFolder}/build/compile_commands.json"
It works now!

Thanks you!

bobbrow · 2020-04-16T16:50:50Z

use #include <QGuiApplication> Wont' work, it says:
can't open "QtGui/qtguiglobal.h" (dependency of "QGuiApplication").

Ah yes, that's a problem if the dependencies are all using the framework syntax. 🤦‍♂️ Thanks for opening the bug for CMake Tools.

julee · 2020-04-17T01:49:52Z

use #include <QGuiApplication> Wont' work, it says:
can't open "QtGui/qtguiglobal.h" (dependency of "QGuiApplication").

Ah yes, that's a problem if the dependencies are all using the framework syntax. 🤦‍♂️ Thanks for opening the bug for CMake Tools.

Open a issue:
CMake Tool Issue: Require Pass -iframework Options to C/C++ Extension

sean-mcmanus added bug Language Service investigate: repro This issue's repro steps needs to be investigated/confirmed labels Mar 20, 2019

sean-mcmanus changed the title ~~macFramework path isn't working?~~ macFrameworkPath isn't working? Mar 20, 2019

bobbrow mentioned this issue Mar 20, 2019

macOS framework support for IntelliSense #970

Closed

sean-mcmanus mentioned this issue Jan 7, 2020

Add support for -iframework in compile_commands.json (Intellisense stopped working for Qt libraries on Mac only) #4819

Closed

julee mentioned this issue Apr 16, 2020

Require Pass -iframework Options to C/C++ Extension microsoft/vscode-cmake-tools#1178

Closed

bobbrow closed this as completed Apr 16, 2020

github-actions bot locked and limited conversation to collaborators Oct 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

macFrameworkPath isn't working? #3323

macFrameworkPath isn't working? #3323

sean-mcmanus commented Mar 20, 2019

jbltx commented Mar 21, 2019

sean-mcmanus commented Mar 21, 2019

julee commented Mar 24, 2020

sean-mcmanus commented Mar 25, 2020

julee commented Mar 26, 2020

julee commented Apr 15, 2020

sean-mcmanus commented Apr 15, 2020

julee commented Apr 16, 2020

julee commented Apr 16, 2020

bobbrow commented Apr 16, 2020

bobbrow commented Apr 16, 2020

julee commented Apr 16, 2020

julee commented Apr 16, 2020

bobbrow commented Apr 16, 2020

julee commented Apr 17, 2020

macFrameworkPath isn't working? #3323

macFrameworkPath isn't working? #3323

Comments

sean-mcmanus commented Mar 20, 2019

jbltx commented Mar 21, 2019

sean-mcmanus commented Mar 21, 2019

julee commented Mar 24, 2020

sean-mcmanus commented Mar 25, 2020

julee commented Mar 26, 2020

julee commented Apr 15, 2020

sean-mcmanus commented Apr 15, 2020

julee commented Apr 16, 2020

julee commented Apr 16, 2020

bobbrow commented Apr 16, 2020

bobbrow commented Apr 16, 2020

julee commented Apr 16, 2020

julee commented Apr 16, 2020

bobbrow commented Apr 16, 2020

julee commented Apr 17, 2020