Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run tests when the build fails #3366

Closed
quyykk opened this issue Oct 4, 2023 · 0 comments
Closed

Don't run tests when the build fails #3366

quyykk opened this issue Oct 4, 2023 · 0 comments
Assignees
@gcampbell-msft
Labels
bug a bug in the product Feature: Test Explorer fixed (release pending) fixed in pre-release and is pending official release investigation needed issues needs a developer assigned to it and investigation done in order to implement a fix
Milestone
1.17

Comments

@quyykk
Copy link

quyykk commented Oct 4, 2023

Brief Issue Summary

  1. Make a change to your source file which will make the build fail
  2. Click on any run test button in the Testing sidebar
  3. The extension recompiles
  4. There's a build failure from the compiler
  5. The extension still tries to run the tests

That last step shouldn't happen. If the build fails to compile, then the tests should not be run.

As a side note, the tests don't run if you use the "Run CTest" button in the toolbar at the bottom instead. This only occurs when using the buttons on the sidebar.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response
@gcampbell-msft gcampbell-msft added bug a bug in the product Feature: Test Explorer repro needed This needs to be reproduced and repro steps detailed either in a comment or in the discussion. investigation needed issues needs a developer assigned to it and investigation done in order to implement a fix and removed repro needed This needs to be reproduced and repro steps detailed either in a comment or in the discussion. labels Oct 13, 2023
@gcampbell-msft gcampbell-msft added this to the On Deck milestone Oct 13, 2023
@gcampbell-msft gcampbell-msft modified the milestones: On Deck, 1.17 Dec 12, 2023
@gcampbell-msft gcampbell-msft self-assigned this Dec 20, 2023
@gcampbell-msft gcampbell-msft mentioned this issue Dec 20, 2023
Merged
@gcampbell-msft gcampbell-msft added the fixed (release pending) fixed in pre-release and is pending official release label Jan 2, 2024
@rjaegers rjaegers mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcampbell-msft gcampbell-msft

Labels
bug a bug in the product Feature: Test Explorer fixed (release pending) fixed in pre-release and is pending official release investigation needed issues needs a developer assigned to it and investigation done in order to implement a fix
Projects
CMake Tools
Status: Completed
Milestone
1.17
Development

No branches or pull requests
2 participants
@quyykk @gcampbell-msft