Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings show up as errors in Problems view #2708

Closed
MathiasMagnus opened this issue Aug 25, 2022 · 1 comment · Fixed by #2710
Closed

Deprecation warnings show up as errors in Problems view #2708

MathiasMagnus opened this issue Aug 25, 2022 · 1 comment · Fixed by #2710
Labels
bug a bug in the product Feature: diagnostics issues with problem matchers for compiler output
Projects
1.12
Milestone
1.12

Comments

@MathiasMagnus
Copy link
Contributor

Brief Issue Summary

message(DEPRECATION ...) which print CMake Deprecation Warning at <file>:<line> (message): <message> show up as errors, whereas it's a warning, which is even inside the message. Could the extension treat these messages as warnings and not errors? (Yellow vs. red sguiggly, ability to filter out as warning in Problems from real errors, etc.)

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

kép
@elahehrashedi elahehrashedi added the bug a bug in the product label Aug 25, 2022
@bobbrow bobbrow mentioned this issue Aug 25, 2022
Merged
@elahehrashedi
Copy link
Contributor

It looks like the code is not setting a severity level for deprecation warnings. We have a fix for this in #PR2710

@bobbrow bobbrow added the Feature: diagnostics issues with problem matchers for compiler output label Aug 25, 2022
@bobbrow bobbrow added this to the 1.12 milestone Aug 26, 2022
@bobbrow bobbrow added this to Triage in 1.12 via automation Aug 26, 2022
@bobbrow bobbrow linked a pull request Aug 26, 2022 that will close this issue
Use the Warning severity for deprecation messages #2710
Merged
@bobbrow bobbrow moved this from Triage to Done in 1.12 Aug 26, 2022
@bobbrow bobbrow closed this as completed Aug 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug a bug in the product Feature: diagnostics issues with problem matchers for compiler output
Projects
No open projects
1.12
Done
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Use the Warning severity for deprecation messages microsoft/vscode-cmake-tools
3 participants
@MathiasMagnus @bobbrow @elahehrashedi