Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect vscode setting insertSpaces when updating preset files via gui #2677

Closed
david-fong opened this issue Aug 8, 2022 · 2 comments · Fixed by #2678
Closed

respect vscode setting insertSpaces when updating preset files via gui #2677

david-fong opened this issue Aug 8, 2022 · 2 comments · Fixed by #2678
Labels
bug a bug in the product Feature: UI
Projects
1.12
Milestone
1.12

Comments

@david-fong
Copy link
Contributor

Brief Issue Summary

Currently, when adding a new cmake preset via the gui action, the edits made to the CMakePresets.json file will always use spaces for indentation. It would be a nice quality of life feature if it either detected the indentation style by reading the file contents, or checked the vscode settings for insertSpaces to decide whether to use tabs or spaces.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response
@elahehrashedi elahehrashedi added Feature: UI enhancement an enhancement to the product that is either not present or an improvement to an existing feature bug a bug in the product and removed enhancement an enhancement to the product that is either not present or an improvement to an existing feature labels Aug 8, 2022
@elahehrashedi elahehrashedi mentioned this issue Aug 8, 2022
Merged
@elahehrashedi
Copy link
Contributor

We have a fix ready for this issue. #2678

@bobbrow bobbrow linked a pull request Aug 8, 2022 that will close this issue
get Indentation of preset files #2678
Merged
@elahehrashedi elahehrashedi added this to Triage in 1.12 via automation Aug 8, 2022
@elahehrashedi elahehrashedi added this to the 1.12 milestone Aug 8, 2022
@bobbrow bobbrow moved this from Triage to In Progress in 1.12 Aug 8, 2022
@david-fong
Copy link
Contributor Author

Awesome. Thank you!

1.12 automation moved this from In Progress to Done Aug 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug a bug in the product Feature: UI
Projects
No open projects
1.12
Done
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

get Indentation of preset files microsoft/vscode-cmake-tools
2 participants
@elahehrashedi @david-fong