Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to included files not triggering reconfigure #2526

Closed
BMBurstein opened this issue Apr 28, 2022 · 2 comments · Fixed by #2548
Closed

changes to included files not triggering reconfigure #2526

BMBurstein opened this issue Apr 28, 2022 · 2 comments · Fixed by #2548
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: configure fixed (release pending) fixed in pre-release and is pending official release help wanted we currently are not planning work on this and would like help from the open source community
Projects
1.12
Milestone
1.12

Comments

@BMBurstein
Copy link

Brief Issue Summary

whenever I make a change to a CMakeLists.txt file, it triggers a reconfigure. But if I have e.g. include(file.cmake) in the CMakeLists.txt file and I change file.cmake, it doesn't trigger an automatic reconfigure. Is it possible to do this?

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response
@elahehrashedi elahehrashedi added the enhancement an enhancement to the product that is either not present or an improvement to an existing feature label Apr 29, 2022
@bobbrow bobbrow added help wanted we currently are not planning work on this and would like help from the open source community Feature: configure labels Apr 29, 2022
@elahehrashedi
Copy link
Contributor

elahehrashedi commented Apr 29, 2022 •
edited by bobbrow
Loading

This feature is not currently available, but we can add it in the future. We may not be able to implement this feature immediately, but we appreciate any help from the community.

@bobbrow bobbrow added this to the Backlog milestone Apr 29, 2022
@chausner chausner mentioned this issue May 15, 2022
Merged
@bobbrow bobbrow linked a pull request Jul 1, 2022 that will close this issue
Use CMake driver to detect changes in CMake files #2548
Merged
@bobbrow bobbrow added the fixed (release pending) fixed in pre-release and is pending official release label Jul 1, 2022
@bobbrow bobbrow closed this as completed Jul 1, 2022
@bobbrow
Copy link
Member

bobbrow commented Jul 1, 2022

This was fixed with PR #2548 and is available starting in version 1.12.8 (pre-release).

@bobbrow bobbrow added this to Triage in 1.12 via automation Jul 1, 2022
@bobbrow bobbrow modified the milestones: Backlog, 1.12 Jul 1, 2022
@bobbrow bobbrow moved this from Triage to Done in 1.12 Jul 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: configure fixed (release pending) fixed in pre-release and is pending official release help wanted we currently are not planning work on this and would like help from the open source community
Projects
No open projects
1.12
Done
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Use CMake driver to detect changes in CMake files chausner/vscode-cmake-tools
3 participants
@BMBurstein @bobbrow @elahehrashedi