Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlink loop causes max cpu usage #2257

Closed
jeffr-spire opened this issue Nov 19, 2021 · 3 comments
Closed

symlink loop causes max cpu usage #2257

jeffr-spire opened this issue Nov 19, 2021 · 3 comments
Labels
bug a bug in the product Feature: activation related to extension activation fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
Milestone

Comments

@jeffr-spire
Copy link

See microsoft/vscode#137478 (comment)

The problem described in that issue recurs when this extension is enabled and a CMakeLists.txt fie is present in the project.

@bobbrow
Copy link
Member

bobbrow commented Nov 22, 2021

I was able to reproduce this issue. It seems to be triggered when we build the list of potential folders with CMakeLists.txt in them for the case where either:

  1. CMakeLists.txt is not in the root folder
  2. cmake.sourceDirectory setting is not set

@bobbrow bobbrow added bug a bug in the product Feature: activation related to extension activation IMPORTANT labels Nov 22, 2021
@bobbrow bobbrow added this to the On Deck milestone Nov 22, 2021
@bobbrow bobbrow added this to Triage in 1.10 via automation Nov 22, 2021
@bobbrow bobbrow moved this from Triage to To do in 1.10 Nov 22, 2021
@bobbrow bobbrow moved this from To do to In progress in 1.10 Nov 22, 2021
@bobbrow bobbrow added this to In progress in 1.9.2 Nov 22, 2021
@bobbrow bobbrow removed this from In progress in 1.10 Nov 23, 2021
@bobbrow bobbrow modified the milestones: On Deck, 1.9.2 Nov 23, 2021
@bobbrow bobbrow added the fixed (release pending) fixed in pre-release and is pending official release label Nov 23, 2021
@bobbrow bobbrow moved this from In progress to Done in 1.9.2 Nov 23, 2021
@bobbrow
Copy link
Member

bobbrow commented Nov 24, 2021

We plan to release the fix for this on Monday. If you would like to verify the fix in a pre-release version of the extension, please do the following:

  1. Download the VSIX here: https://github.com/microsoft/vscode-cmake-tools/suites/4455203062/artifacts/118295075
  2. Unzip the VSIX file from the archive
  3. Invoke the Install from VSIX... command in VS Code and select the VSIX file from step 2.

@bobbrow
Copy link
Member

bobbrow commented Nov 29, 2021

The fix for this has been released in 1.9.2.

@bobbrow bobbrow closed this as completed Nov 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product Feature: activation related to extension activation fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
No open projects
1.9.2
Done
Development

No branches or pull requests

2 participants