CMakePresets: "warnings" field settings are not passed on to CMake

[hwmaier]

When creating the command line to invoke CMake the warnings field is ignored and it is impossible to pass warning command line arguments to CMake. For example in this case --no-warn-unused-cli shall be passed on to CMake.

Example:

    "configurePresets": [
        {
           ...
            "warnings": {"unusedCli": false},
           ...
        },

As a side note, this issue would not occur if this plugin would use the --preset argument to invoke CMake rather than building its own command line.

[bobbrow]

Thank you for reporting this issue. Looks like a simple logic mistake in the code. @xisui-MSFT could you fix this real quick?

vscode-cmake-tools/src/preset.ts

Line 1247 in 192fec8

preset.warnings.unusedCli && result.push('--no-warn-unused-cli');

As a side note, this issue would not occur if this plugin would use the --preset argument to invoke CMake rather than building its own command line.

Yes, this is likely possible, but Kitware has requested that IDE's/editors do their own parsing instead of using --preset (reference)

[hwmaier]

As a side note, this issue would not occur if this plugin would use the --preset argument to invoke CMake rather than building its own command line.

Yes, this is likely possible, but Kitware has requested that IDE's/editors do their own parsing instead of using --preset (reference)

Also Thanks for this explanation. I have been wondering what the rationale was to reconstruct rather using the --preset argument. I suggest to put that explanation into the doc as I am sure it comes up again.

[bobbrow]

I'm not sure which doc would be an appropriate place for it. People would ask anyway. 😅

We committed a fix for this. If you want to try it out, you can download the VSIX here: https://github.com/microsoft/vscode-cmake-tools/suites/3342925255/artifacts/78474075
and then run the "Install from VSIX..." command in VS Code.