Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value of CMAKE_GENERATOR_TOOLSET:INTERNAL is getting prefixed with "host=" every time we try to configure a project #1613

Closed
bvbasavaraju opened this issue Jan 6, 2021 · 2 comments · Fixed by #1629
Assignees
Labels
bug a bug in the product Feature: cache editor
Milestone

Comments

@bvbasavaraju
Copy link

bvbasavaraju commented Jan 6, 2021

Brief Issue Summary

After Making change in GUI, editing the CMake configuration using "Edit CMake Cache (UI)" and saving the changes,
value of "CMAKE_GENERATOR_TOOLSET:INTERNAL" in cache file will end up with prefixing the "host=" to already existing value.

Ex:
CMAKE_GENERATOR_TOOLSET:INTERNAL=host=x86

if above value is already present, I make the change in CMakeCache using Edit CMake Cache(UI) option and saving it will result in below statement in CMake cache file

CMAKE_GENERATOR_TOOLSET:INTERNAL=host=host=x86.

This will result in the error while configuring the project like below:
[cmake] CMake Error: Error: generator toolset: host=x86
[cmake] Does not match the toolset used previously: host=host=x86

I had to manually edit the CMakeCache file again, to have the correct value and configure again.

Expected:

it should should prefix the value on every Save!

@bobbrow
Copy link
Member

bobbrow commented Jan 6, 2021

Thank you for reporting this. I think we have enough information to investigate. We'll let you know if we need anything else.

@andreeis
Copy link
Contributor

We almost have CMake Tools 1.6.0 release out the door. Until then, if you want, you can also verify if this problem has been fixed correctly by installing the vsix built here: https://github.com/microsoft/vscode-cmake-tools/actions/runs/557242002#artifacts.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product Feature: cache editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants