Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the extension when no CMakeLists is present #1578

Closed
songyang-dev opened this issue Nov 30, 2020 · 7 comments
Closed

Disable the extension when no CMakeLists is present #1578

songyang-dev opened this issue Nov 30, 2020 · 7 comments
Assignees
Labels
bug a bug in the product duplicate a duplicate of an already present issue Feature: activation related to extension activation fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Milestone

Comments

@songyang-dev
Copy link

Hello! I like this extension but sometimes I am not working on a CMake project in my workspace and this extension starts to search for kits and configurations right away. It would be nice if the extension would not aggressively start on every workspace in VSCode.

@bobbrow
Copy link
Member

bobbrow commented Dec 1, 2020

Thank you for your issue report. I had thought we disabled the extension in cases where there is no CMakeLists.txt found, but we will go back and look at the code to see what is missing.

To help us understand better, are you opening a folder that happens to have a CMakeLists.txt buried in one of the subfolders?

@bobbrow bobbrow added bug a bug in the product Feature: activation related to extension activation labels Dec 1, 2020
@andreeis
Copy link
Contributor

andreeis commented Dec 1, 2020

I vaguely remember that there is some kits searching logic triggered before the project has the chance to first configure. We need to fix that, of course.
@XsongyangX , as a workaround you can select a kit, doesn't matter which one (let's say 'unspecified'), then you should see a popup notifying you that there is no CMakeLists found, with an option button to ignore for the current project. Press that and you should not see any activation happening after that. Let us know how that works.

@songyang-dev
Copy link
Author

To help us understand better, are you opening a folder that happens to have a CMakeLists.txt buried in one of the subfolders?

I was in a leaf folder. So no subfolders.

@andreeis I'll try that next time.

@songyang-dev songyang-dev changed the title [Suggestion] Disable the extension when no CMakeLists is present Disable the extension when no CMakeLists is present Dec 4, 2020
@songyang-dev
Copy link
Author

songyang-dev commented Dec 4, 2020

I believe this issue is linked with #1564, #1518, #1461

@bobbrow bobbrow added this to the 1.6.0 milestone Jan 19, 2021
@bobbrow bobbrow added this to Triage in 1.6.0 via automation Jan 19, 2021
@bobbrow bobbrow moved this from Triage to To Do in 1.6.0 Jan 19, 2021
@bobbrow bobbrow removed this from To Do in 1.6.0 Feb 8, 2021
@bobbrow bobbrow added this to ToDo in 1.7.0 Feb 8, 2021
@bobbrow bobbrow modified the milestones: 1.6.0, 1.7.0 Feb 8, 2021
@andreeis andreeis added the duplicate a duplicate of an already present issue label Mar 1, 2021
@andreeis
Copy link
Contributor

andreeis commented Mar 1, 2021

Fix in PR now. Duplicate of #1007.

@andreeis andreeis closed this as completed Mar 1, 2021
@bobbrow bobbrow removed this from ToDo in 1.7.0 Mar 1, 2021
@andreeis andreeis added the fixed (release pending) fixed in pre-release and is pending official release label Mar 2, 2021
@andreeis andreeis added this to Done in 1.7.0 Mar 2, 2021
@andreeis andreeis removed this from Done in 1.7.0 Mar 2, 2021
@JanHildenbrandBosch
Copy link

Can this in any way be disabled over a configuration?
We are having currently the issue that the cmakelist.txt will be created after the extension is loaded. But then the extension bar is never loaded.

@bobbrow
Copy link
Member

bobbrow commented Apr 21, 2021

@JanHildenbrandBosch this issue is closed so I moved your comment to a new issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product duplicate a duplicate of an already present issue Feature: activation related to extension activation fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
None yet
Development

No branches or pull requests

4 participants