From 68ee702ab4abee3cf4731aecfc96f87336c9b640 Mon Sep 17 00:00:00 2001
From: TW3 <2378845-TW3@users.noreply.gitlab.com>
Date: Sun, 7 Mar 2021 15:33:02 +0000
Subject: [PATCH] [QtWebEngine] - Fix build failure

This commit fixes an issue
where the build fails on
X86_64 Windows 10 Pro
with a message similar to:
'PATCHES no such argument'
printed to the console output.

It also makes a few small
changes for sanity.
Build trees for QtWebEngine
come in at between 40GB-50GB
and the minimum recommended
RAM size for building
Chromium according to
google is 8GB.
The port shouldn't be
building debug by
default due to it's
size and the fact that
you likely only want
debug if you are a
Qt developer or
are working on vcpkg.
The options "" is
intentionally left
blank due to the fact
that it allows the string
-webengine-proprietary-codecs
to be easily be added in case
you have licences for that
kind of thing.
Without that option enabled,
many html5 videos do not
work in QtWebEngine.
Maybe adding a configuration
switch for proprietary-codecs
is something to think about
for the future?

Enjoy!
---
 ports/qt5-webengine/portfile.cmake | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/ports/qt5-webengine/portfile.cmake b/ports/qt5-webengine/portfile.cmake
index 797d5fedb46793..e9e8ac3907eac0 100644
--- a/ports/qt5-webengine/portfile.cmake
+++ b/ports/qt5-webengine/portfile.cmake
@@ -1,7 +1,7 @@
 vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)
-#set(VCPKG_BUILD_TYPE release) #You probably want to set this to reduce build type and space requirements
-message(STATUS "${PORT} requires a lot of free disk space (>300GB), ram (>32 GB) and time (>4h per configuration) to be successfully build.\n\
--- As such ${PORT} is not properly tested.\n\
+set(VCPKG_BUILD_TYPE release) # You probably want to set this to reduce build type and space requirements
+message(STATUS "${PORT} requires a lot of free disk space (>50GB), ram (>8 GB) and time (>4h per configuration) to be successfully build.\n\
+-- As such ${PORT} is currently EXPERIMENTAL.\n\
 -- If ${PORT} fails post build validation please open up an issue. \n\
 -- If it fails due to post validation the successfully installed files can be found in ${CURRENT_PACKAGES_DIR} \n\
 -- and just need to be copied into ${CURRENT_INSTALLED_DIR}")
@@ -36,14 +36,24 @@ vcpkg_add_to_path(PREPEND "${PYTHON2_DIR}")
 vcpkg_add_to_path(PREPEND "${GPERF_DIR}")
 vcpkg_add_to_path(PREPEND "${NINJA_DIR}")
 
-set(PATCHES common.pri.patch 
-            gl.patch
-            build_1.patch
-            build_2.patch
-            build_3.patch)
+set(PATCHES
+        common.pri.patch
+        gl.patch
+        build_1.patch
+        build_2.patch
+        build_3.patch
+)
 
 if(NOT VCPKG_TARGET_IS_WINDOWS)
-    list(APPEND CORE_OPTIONS "BUILD_OPTIONS" "-webengine-system-libwebp" "-webengine-system-ffmpeg" "-webengine-system-icu")
+    set(OPTIONS
+            "-webengine-system-libwebp"
+            "-webengine-system-ffmpeg"
+            "-webengine-system-icu"
+    )
+else()
+    set(OPTIONS
+            ""
+    )
 endif()
 
-qt_submodule_installation(${CORE_OPTIONS} PATCHES ${PATCHES})
+qt_submodule_installation(PATCHES ${PATCHES} BUILD_OPTIONS ${OPTIONS})