From a2a37956445e83f7d14db8a86e86c7a61f93d6c6 Mon Sep 17 00:00:00 2001 From: James Liu Date: Thu, 4 Jun 2020 11:11:01 +1000 Subject: [PATCH 1/3] docs: fix CMakeLists example for SQLite3 --- docs/examples/installing-and-using-packages.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/examples/installing-and-using-packages.md b/docs/examples/installing-and-using-packages.md index 73f9d29a923253..d8f32a8ff1744b 100644 --- a/docs/examples/installing-and-using-packages.md +++ b/docs/examples/installing-and-using-packages.md @@ -118,10 +118,12 @@ Now let's make a simple CMake project with a main file. cmake_minimum_required(VERSION 3.0) project(test) -find_package(Sqlite3 REQUIRED) +find_package(SQLite3 REQUIRED) add_executable(main main.cpp) -target_link_libraries(main sqlite3) + +target_include_directories(main PRIVATE ${SQLite3_INCLUDE_DIRS}) +target_link_libraries(main ${SQLite3_LIBRARIES}) ``` ```cpp // main.cpp From 4957c9182bff4b0aefc26fe61c4e406d952c1059 Mon Sep 17 00:00:00 2001 From: James Liu Date: Thu, 4 Jun 2020 13:58:29 +1000 Subject: [PATCH 2/3] docs: simplify CMake config --- docs/examples/installing-and-using-packages.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/examples/installing-and-using-packages.md b/docs/examples/installing-and-using-packages.md index d8f32a8ff1744b..d4bb28a0883d6b 100644 --- a/docs/examples/installing-and-using-packages.md +++ b/docs/examples/installing-and-using-packages.md @@ -118,12 +118,11 @@ Now let's make a simple CMake project with a main file. cmake_minimum_required(VERSION 3.0) project(test) -find_package(SQLite3 REQUIRED) +find_package(sqlite3 CONFIG REQUIRED) add_executable(main main.cpp) -target_include_directories(main PRIVATE ${SQLite3_INCLUDE_DIRS}) -target_link_libraries(main ${SQLite3_LIBRARIES}) +target_link_libraries(main PRIVATE sqlite3)) ``` ```cpp // main.cpp From 1a4f23f5d141fd3c42aa6c8dd72cef528ac5f05c Mon Sep 17 00:00:00 2001 From: James Liu Date: Fri, 5 Jun 2020 09:26:13 +1000 Subject: [PATCH 3/3] fix: remove extra parenthesis --- docs/examples/installing-and-using-packages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/installing-and-using-packages.md b/docs/examples/installing-and-using-packages.md index d4bb28a0883d6b..82371149bbed97 100644 --- a/docs/examples/installing-and-using-packages.md +++ b/docs/examples/installing-and-using-packages.md @@ -122,7 +122,7 @@ find_package(sqlite3 CONFIG REQUIRED) add_executable(main main.cpp) -target_link_libraries(main PRIVATE sqlite3)) +target_link_libraries(main PRIVATE sqlite3) ``` ```cpp // main.cpp