Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Port Request] rubberband #17768

Closed
dreuter opened this issue May 10, 2021 · 3 comments · Fixed by #24549
Closed

[New Port Request] rubberband #17768

dreuter opened this issue May 10, 2021 · 3 comments · Fixed by #24549
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity.

Comments

@dreuter
Copy link
Contributor

dreuter commented May 10, 2021

Library name: rubberband

Library description: High quality software library for audio time-stretching and pitch-shifting.

Source repository URL: https://hg.sr.ht/~breakfastquay/rubberband

Project homepage (if different from the source repository): https://www.breakfastquay.com/rubberband/

I would be happy to create a draft pull request with my portfile, which probably still needs a bit of work to not accidentally pick up system libraries.
@JonLiu1993 JonLiu1993 added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels May 10, 2021
@dreuter
Copy link
Contributor Author

dreuter commented May 10, 2021

Should I go ahead and create the draft PR?
Your community guidelines state that one should create the issue first ;) which I've done here, but should I wait for feedback or create the PR now?

@autoantwort
Copy link
Contributor

but should I wait for feedback or create the PR now?

I think you can create right now and don't have to wait

@dreuter dreuter mentioned this issue May 11, 2021
Closed
@JackBoosY
Copy link
Contributor

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now, consider making a pull request instead.

@JackBoosY JackBoosY added the info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity. label Mar 24, 2022
@daschuer daschuer mentioned this issue May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. info:new-port-unresolved This port has not been added to vcpkg; the issue was closed for inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new port] Add rubberband daschuer/vcpkg
[rubberband] Add new port dreuter/vcpkg
4 participants
@dreuter @autoantwort @JackBoosY @JonLiu1993