Skip to content

Commit 6d0c26e

Browse files
Copilotjakebailey
andcommitted
Fix nil pointer dereference and accept baselines
- Add nil check for node.Name() in checkWeakMapSetCollision - Accept baseline for privateNameWeakMapCollision test Co-authored-by: jakebailey <[email protected]>
1 parent 301ee4a commit 6d0c26e

File tree

3 files changed

+19
-22
lines changed

3 files changed

+19
-22
lines changed

internal/checker/checker.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10241,7 +10241,8 @@ func (c *Checker) recordPotentialCollisionWithWeakMapSetInGeneratedCode(node *as
1024110241
func (c *Checker) checkWeakMapSetCollision(node *ast.Node) {
1024210242
enclosingBlockScope := ast.GetEnclosingBlockScopeContainer(node)
1024310243
if c.nodeLinks.Get(enclosingBlockScope).flags&NodeCheckFlagsContainsClassWithPrivateIdentifiers != 0 {
10244-
if name := node.Name(); ast.IsIdentifier(name) {
10244+
name := node.Name()
10245+
if name != nil && ast.IsIdentifier(name) {
1024510246
c.errorSkippedOnNoEmit(node, diagnostics.Compiler_reserves_name_0_when_emitting_private_identifier_downlevel, name.Text())
1024610247
}
1024710248
}
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
privateNameWeakMapCollision.ts(2,9): error TS18027: Compiler reserves name 'WeakMap' when emitting private identifier downlevel.
2+
privateNameWeakMapCollision.ts(3,9): error TS18027: Compiler reserves name 'WeakSet' when emitting private identifier downlevel.
3+
4+
5+
==== privateNameWeakMapCollision.ts (2 errors) ====
6+
function test() {
7+
let WeakMap;
8+
~~~~~~~
9+
!!! error TS18027: Compiler reserves name 'WeakMap' when emitting private identifier downlevel.
10+
let WeakSet;
11+
~~~~~~~
12+
!!! error TS18027: Compiler reserves name 'WeakSet' when emitting private identifier downlevel.
13+
class C {
14+
#x;
15+
}
16+
}
17+

testdata/baselines/reference/submodule/compiler/privateNameWeakMapCollision.errors.txt.diff

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)