From bf96b2692145138c051b85d65d614861be82f67b Mon Sep 17 00:00:00 2001 From: Armando Aguirre Sepulveda Date: Mon, 1 Jul 2024 17:41:21 -0700 Subject: [PATCH 1/6] Refactored old server errors --- src/main.ts | 69 +++++++++-- test/__snapshots__/main.test.ts.snap | 170 +++++++++++++++++++++++++++ test/main.test.ts | 73 ++++++++++-- 3 files changed, 291 insertions(+), 21 deletions(-) diff --git a/src/main.ts b/src/main.ts index cd54639..b7846e5 100644 --- a/src/main.ts +++ b/src/main.ts @@ -335,10 +335,7 @@ async function getTsServerRepoResult( installCommands, }; - if (oldServerFailed && !newServerFailed) { - return { status: "Detected interesting changes", tsServerResult } - } - if (!newServerFailed) { + if (!oldServerFailed && !newServerFailed) { return { status: "Detected no interesting changes" }; } @@ -404,25 +401,77 @@ function createOldErrorSummary(summaries: Summary[]): string { let text = `
-${errorMessage} +New server no longer reports this error: ${errorMessage} \`\`\` ${oldServerError} \`\`\` -

Repos no longer reporting the error

-
`; diff --git a/test/__snapshots__/main.test.ts.snap b/test/__snapshots__/main.test.ts.snap index 4cbd749..be49010 100644 --- a/test/__snapshots__/main.test.ts.snap +++ b/test/__snapshots__/main.test.ts.snap @@ -1,5 +1,175 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP +exports[`main outputs old server errors 1`] = ` +[MockFunction] { + "calls": [ + [ + "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", + "Req #123 - cursedCommand +Some error. Could not do something. +Maybe a Debug fail. + at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1) + at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2) + at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3) + at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4) + at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)", + ], + [ + "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", + "

Maybe a Debug fail.

+ +\`\`\` +Req #123 - cursedCommand + at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1) + at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2) + at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3) + at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4) + at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5) +\`\`\` + +

Affected repos

+
+MockRepoOwner/MockRepoName +Raw error text: RepoResults123/MockRepoOwner.MockRepoName.rawError.txt in the artifact folder
+Replay commands: RepoResults123/MockRepoOwner.MockRepoName.replay.txt in the artifact folder +

Last few requests

+ +\`\`\`json +{"rootDirPlaceholder":"@PROJECT_ROOT@","serverArgs":["--disableAutomaticTypingAcquisition"]} +{"seq":1,"type":"request","command":"configure","arguments":{"preferences":{"disableLineTextInReferences":true,"includePackageJsonAutoImports":"auto","includeCompletionsForImportStatements":true,"includeCompletionsWithSnippetText":true,"includeAutomaticOptionalChainCompletions":true,"includeCompletionsWithInsertText":true,"includeCompletionsWithClassMemberSnippets":true,"allowIncompleteCompletions":true,"includeCompletionsForModuleExports":false},"watchOptions":{"excludeDirectories":["**/node_modules"]}}} +{"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/sample_repoName.config.js","projectRootPath":"@PROJECT_ROOT@"}]}} +{"seq":3,"type":"request","command":"cursedCommand","arguments":{"file":"@PROJECT_ROOT@/src/sampleTsFile.ts","line":1,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}} +\`\`\` + +

Repro steps

+ +\`\`\`bash +#!/bin/bash + +git clone https://github.com/MockRepoOwner/MockRepoName --recurse-submodules +git -C "./MockRepoName" reset --hard 57b462387e88aa7e363af0daf867a5dc1e83a935 +# Install packages (exact steps are below, but it might be easier to follow the repo readme) +npm --prefix "./dirA" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +npm --prefix "./dirB/dirC" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +npm --prefix "./dirD/dirE/dirF" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +downloadUrl=$(curl -s "PLACEHOLDER_GETARTIFACTS_API?artifactName=RepoResults123&api-version=7.0" | jq -r ".resource.downloadUrl") +wget -O RepoResults123.zip "$downloadUrl" +unzip -p RepoResults123.zip RepoResults123/MockRepoOwner.MockRepoName.replay.txt > MockRepoOwner.MockRepoName.replay.txt +npm install --no-save @typescript/server-replay +\`\`\` + +To run the repro: +\`\`\`bash +# \`npx tsreplay --help\` to learn about helpful switches for debugging, logging, etc. +npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt +\`\`\` + +
+", + { + "encoding": "utf-8", + }, + ], + [ + "/RepoResults123/metadata.json", + "{"newTsResolvedVersion":"1.1.1","oldTsResolvedVersion":"0.0.0","statusCounts":{"Detected interesting changes":1}}", + { + "encoding": "utf-8", + }, + ], + [ + "/RepoResults123/!718e48b799650d4b66e5d80ad6bac7b9.results.txt", + " +
+New server no longer reports this error: Maybe a Debug fail. + +\`\`\` +Req #123 - cursedCommand + at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1) + at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2) + at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3) + at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4) + at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5) +\`\`\` + +

Affected repos

+
+MockRepoOwner/MockRepoName +Raw error text: RepoResults123/MockRepoOwner.MockRepoName.rawError.txt in the artifact folder
+Replay commands: RepoResults123/MockRepoOwner.MockRepoName.replay.txt in the artifact folder +

Last few requests

+ +\`\`\`json +{"rootDirPlaceholder":"@PROJECT_ROOT@","serverArgs":["--disableAutomaticTypingAcquisition"]} +{"seq":1,"type":"request","command":"configure","arguments":{"preferences":{"disableLineTextInReferences":true,"includePackageJsonAutoImports":"auto","includeCompletionsForImportStatements":true,"includeCompletionsWithSnippetText":true,"includeAutomaticOptionalChainCompletions":true,"includeCompletionsWithInsertText":true,"includeCompletionsWithClassMemberSnippets":true,"allowIncompleteCompletions":true,"includeCompletionsForModuleExports":false},"watchOptions":{"excludeDirectories":["**/node_modules"]}}} +{"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/sample_repoName.config.js","projectRootPath":"@PROJECT_ROOT@"}]}} +{"seq":3,"type":"request","command":"cursedCommand","arguments":{"file":"@PROJECT_ROOT@/src/sampleTsFile.ts","line":1,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}} +\`\`\` + +

Repro steps

+ +\`\`\`bash +#!/bin/bash + +git clone https://github.com/MockRepoOwner/MockRepoName --recurse-submodules +git -C "./MockRepoName" reset --hard 57b462387e88aa7e363af0daf867a5dc1e83a935 +# Install packages (exact steps are below, but it might be easier to follow the repo readme) +npm --prefix "./dirA" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +npm --prefix "./dirB/dirC" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +npm --prefix "./dirD/dirE/dirF" install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q +downloadUrl=$(curl -s "PLACEHOLDER_GETARTIFACTS_API?artifactName=RepoResults123&api-version=7.0" | jq -r ".resource.downloadUrl") +wget -O RepoResults123.zip "$downloadUrl" +unzip -p RepoResults123.zip RepoResults123/MockRepoOwner.MockRepoName.replay.txt > MockRepoOwner.MockRepoName.replay.txt +npm install --no-save @typescript/server-replay +\`\`\` + +To run the repro: +\`\`\`bash +# \`npx tsreplay --help\` to learn about helpful switches for debugging, logging, etc. +npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt +\`\`\` + +
+ +
+", + { + "encoding": "utf-8", + }, + ], + [ + "/RepoResults123/metadata.json", + "{"newTsResolvedVersion":"1.1.1","oldTsResolvedVersion":"0.0.0","statusCounts":{"Detected interesting changes":1}}", + { + "encoding": "utf-8", + }, + ], + ], + "results": [ + { + "type": "return", + "value": undefined, + }, + { + "type": "return", + "value": undefined, + }, + { + "type": "return", + "value": undefined, + }, + { + "type": "return", + "value": undefined, + }, + { + "type": "return", + "value": undefined, + }, + ], +} +`; + exports[`main outputs server errors 1`] = ` [MockFunction] { "calls": [ diff --git a/test/main.test.ts b/test/main.test.ts index c29f971..51c5cd3 100644 --- a/test/main.test.ts +++ b/test/main.test.ts @@ -2,6 +2,7 @@ import { getTscRepoResult, downloadTsRepoAsync, mainAsync } from '../src/main' import { execSync } from "child_process" import path = require("path") import { createCopyingOverlayFS } from '../src/utils/overlayFS' +import { SpawnResult } from '../src/utils/execUtils'; jest.mock('random-seed', () => ({ create: () => { @@ -27,17 +28,7 @@ jest.mock("../src/utils/execUtils", () => ({ return {}; } - return { - stdout: JSON.stringify({ - "request_seq": "123", - "command": "cursedCommand", - "message": "Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)" - }), - stderr: '', - code: 5, - signal: null, - - } + return typeScriptSpawnResult(args); }), execAsync: async (cwd: string, command: string) => { if (command.startsWith('npm pack typescript@latest')) { @@ -110,6 +101,14 @@ jest.mock('../src/utils/installPackages', () => { } }); +let typeScriptSpawnResult: (args: readonly string[]) => SpawnResult; + +const errorStdout = JSON.stringify({ + "request_seq": "123", + "command": "cursedCommand", + "message": "Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)" +}); + describe("main", () => { jest.setTimeout(10 * 60 * 1000); @@ -146,6 +145,58 @@ describe("main", () => { it("outputs server errors", async () => { const mockedFs = require('fs'); + typeScriptSpawnResult = () => ({ + stdout: errorStdout, + stderr: '', + code: 5, + signal: null, + + }); + + await mainAsync({ + testType: "github", + tmpfs: false, + entrypoint: 'tsserver', + diagnosticOutput: false, + buildWithNewWhenOldFails: false, + repoListPath: "./artifacts/repos.json", + workerCount: 1, + workerNumber: 1, + oldTsNpmVersion: 'latest', + newTsNpmVersion: 'next', + resultDirName: 'RepoResults123', + prngSeed: 'testSeed', + }); + + // Remove all references to the base path so that snapshot pass successfully. + mockedFs.promises.writeFile.mock.calls.forEach((e: [string, string]) => { + e[0] = e[0].replace(process.cwd(), ""); + }); + + expect(mockedFs.promises.writeFile).toMatchSnapshot(); + }); + + it("outputs old server errors", async () => { + const mockedFs = require('fs'); + + typeScriptSpawnResult = args => { + let isOldServer = args.some(x => x.includes('0.0.0')); + + // Only "old" reports an error. + return isOldServer ? { + stdout: errorStdout, + stderr: '', + code: 5, + signal: null, + } : { + stdout: '', + stderr: '', + code: 0, + signal: null, + }; + + }; + await mainAsync({ testType: "github", tmpfs: false, From fbc8807d7340ee0633dc9efe81b4307e62892124 Mon Sep 17 00:00:00 2001 From: Armando Aguirre Sepulveda Date: Tue, 2 Jul 2024 15:38:39 -0700 Subject: [PATCH 2/6] Fixed missing rawError file --- src/main.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main.ts b/src/main.ts index b7846e5..6603c5e 100644 --- a/src/main.ts +++ b/src/main.ts @@ -310,6 +310,8 @@ async function getTsServerRepoResult( ? prettyPrintServerHarnessOutput(oldSpawnResult.stdout, /*filter*/ false) : `Timed out after ${executionTimeout} ms`)); + await fs.promises.writeFile(rawErrorPath, oldSpawnResult?.stdout ?? `Timed out after ${executionTimeout} ms`); + // We don't want to drown PRs with comments. // Override the results to say nothing interesting changed. if (isPr && newServerFailed && oldSpawnResult) { From bc2ce34a4eaddeb42a7dd0a949427bac132bb59c Mon Sep 17 00:00:00 2001 From: Armando Aguirre Sepulveda Date: Tue, 2 Jul 2024 15:48:36 -0700 Subject: [PATCH 3/6] Added old server version to title and description --- src/postGithubIssue.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/postGithubIssue.ts b/src/postGithubIssue.ts index 3b6e706..9e25f77 100644 --- a/src/postGithubIssue.ts +++ b/src/postGithubIssue.ts @@ -44,12 +44,11 @@ for (const path of metadataFilePaths) { } } -const title = entrypoint === "tsserver" - ? `[ServerErrors][${language}] ${newTscResolvedVersion}` - : `[NewErrors] ${newTscResolvedVersion} vs ${oldTscResolvedVersion}`; + +const title = `${entrypoint === "tsserver" ? `[ServerErrors][${language}]` : `[NewErrors]`} ${newTscResolvedVersion} vs ${oldTscResolvedVersion}`; const description = entrypoint === "tsserver" - ? `The following errors were reported by ${newTscResolvedVersion}` + ? `The following errors were reported by ${newTscResolvedVersion} vs ${oldTscResolvedVersion}` : `The following errors were reported by ${newTscResolvedVersion}, but not by ${oldTscResolvedVersion}`; let header = `${description} [Pipeline that generated this bug](https://typescript.visualstudio.com/TypeScript/_build?definitionId=48) From 9e3f409810b78e6478de7203999c3f0065ec2767 Mon Sep 17 00:00:00 2001 From: Armando Aguirre Sepulveda Date: Tue, 2 Jul 2024 15:50:08 -0700 Subject: [PATCH 4/6] Updated test snapshot --- test/__snapshots__/main.test.ts.snap | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/test/__snapshots__/main.test.ts.snap b/test/__snapshots__/main.test.ts.snap index be49010..723f1e7 100644 --- a/test/__snapshots__/main.test.ts.snap +++ b/test/__snapshots__/main.test.ts.snap @@ -14,6 +14,10 @@ Maybe a Debug fail. at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4) at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)", ], + [ + "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", "

Maybe a Debug fail.

@@ -77,6 +81,10 @@ npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt /ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + ], [ "/RepoResults123/!718e48b799650d4b66e5d80ad6bac7b9.results.txt", " @@ -166,6 +174,14 @@ npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt /ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", "

Maybe a Debug fail.

@@ -261,6 +281,10 @@ npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt Date: Tue, 2 Jul 2024 16:33:28 -0700 Subject: [PATCH 5/6] Fixed snapshot typos --- test/__snapshots__/main.test.ts.snap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/__snapshots__/main.test.ts.snap b/test/__snapshots__/main.test.ts.snap index 723f1e7..bf607da 100644 --- a/test/__snapshots__/main.test.ts.snap +++ b/test/__snapshots__/main.test.ts.snap @@ -16,7 +16,7 @@ Maybe a Debug fail. ], [ "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", @@ -83,7 +83,7 @@ npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt /ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/!718e48b799650d4b66e5d80ad6bac7b9.results.txt", @@ -202,7 +202,7 @@ Maybe a Debug fail. ], [ "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. /nMaybe a Debug fail./n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)/n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)/n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)/n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)/n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", From 291fc5e61d7552d6ebfe928deea86915cfa135c8 Mon Sep 17 00:00:00 2001 From: Armando Aguirre Sepulveda Date: Wed, 3 Jul 2024 13:41:36 -0700 Subject: [PATCH 6/6] whats wrong with me!? Fixed more typos --- test/__snapshots__/main.test.ts.snap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/__snapshots__/main.test.ts.snap b/test/__snapshots__/main.test.ts.snap index bf607da..6966dc4 100644 --- a/test/__snapshots__/main.test.ts.snap +++ b/test/__snapshots__/main.test.ts.snap @@ -16,7 +16,7 @@ Maybe a Debug fail. ], [ "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \\nMaybe a Debug fail.\\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt", @@ -83,7 +83,7 @@ npx tsreplay ./MockRepoName ./MockRepoOwner.MockRepoName.replay.txt /ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \\nMaybe a Debug fail.\\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/!718e48b799650d4b66e5d80ad6bac7b9.results.txt", @@ -202,7 +202,7 @@ Maybe a Debug fail. ], [ "/ts_downloads/base/MockRepoOwner.MockRepoName.rawError.txt", - "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \nMaybe a Debug fail.\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", + "{"request_seq":"123","command":"cursedCommand","message":"Some error. Could not do something. \\nMaybe a Debug fail.\\n at a (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:1:1)\\n at b (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:2:2)\\n at c (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:3:3)\\n at d (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:4:4)\\n at e (/mnt/vss/_work/1/s/typescript-1.1.1/lib/typescript.js:5:5)"}", ], [ "/RepoResults123/718e48b799650d4b66e5d80ad6bac7b9.results.txt",