Skip to content
This repository was archived by the owner on Jun 11, 2020. It is now read-only.

Commit 2bf0404

Browse files
committed
nodeBuiltins depend on @types/node
1 parent 2aab78f commit 2bf0404

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/lib/definition-parser.ts

+7
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,13 @@ function calculateDependencies(
392392
dependencies.push({ name: dependency, version: "*" });
393393
}
394394
}
395+
if (!dependencies.some(d => d.name === "node")) {
396+
for (const dependency of dependencyNames) {
397+
if (nodeBuiltins.has(dependency)) {
398+
throw new Error(`${packageName}${directoryVersion ? `/v${formatTypingVersion(directoryVersion)}` : ""} must /// <reference types="node" /> (or depend on "${dependency}") because it imports "${dependency}".`);
399+
}
400+
}
401+
}
395402

396403
return { dependencies, pathMappings };
397404
}

0 commit comments

Comments
 (0)