Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests/datamodules #978

Open
5 of 12 tasks
adamjstewart opened this issue Dec 26, 2022 · 0 comments
Open
5 of 12 tasks

Remove tests/datamodules #978

adamjstewart opened this issue Dec 26, 2022 · 0 comments
Labels
datamodules PyTorch Lightning datamodules testing Continuous integration testing

Comments

@adamjstewart
Copy link
Collaborator

adamjstewart commented Dec 26, 2022

Summary

I would like to remove (almost) all tests in tests/datamodules and replace them with new tests in tests/trainers that actually ensure our datamodules and trainers are compatible.

Rationale

The current tests simply ensure that the data loaders don't crash. They don't actually test that the datamodules are compatible with our trainers.

Implementation

The bulk of these have already been converted in #329. The remaining tests are:

Alternatives

We may end up keeping some of these that test invalid arguments. The important thing is not that we don't test datamodules standalone, but that we test them with trainers whenever possible.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules testing Continuous integration testing
Projects
None yet
Development

No branches or pull requests

1 participant