You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to remove (almost) all tests in tests/datamodules and replace them with new tests in tests/trainers that actually ensure our datamodules and trainers are compatible.
Rationale
The current tests simply ensure that the data loaders don't crash. They don't actually test that the datamodules are compatible with our trainers.
Implementation
The bulk of these have already been converted in #329. The remaining tests are:
utils (coverage for test_pct == None, do we need this?)
Alternatives
We may end up keeping some of these that test invalid arguments. The important thing is not that we don't test datamodules standalone, but that we test them with trainers whenever possible.
Additional information
No response
The text was updated successfully, but these errors were encountered:
Summary
I would like to remove (almost) all tests in
tests/datamodules
and replace them with new tests intests/trainers
that actually ensure our datamodules and trainers are compatible.Rationale
The current tests simply ensure that the data loaders don't crash. They don't actually test that the datamodules are compatible with our trainers.
Implementation
The bulk of these have already been converted in #329. The remaining tests are:
Alternatives
We may end up keeping some of these that test invalid arguments. The important thing is not that we don't test datamodules standalone, but that we test them with trainers whenever possible.
Additional information
No response
The text was updated successfully, but these errors were encountered: