You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I found that in the function calculate_type_to_num_incoming_edges, tf2_gnn/layers/message_passing/message_passing.py, tf.shapewill be called redundantly in the iteration to get the same value, code here.
Moreover, if users try to add @tf.funtion annotation to speed up this function in graph mode, lots of same nodes will be created in computation graph.
Thus, I think tf.shape should be called only once before the loop.
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
The text was updated successfully, but these errors were encountered:
Hello,
I found that in the function
calculate_type_to_num_incoming_edges
, tf2_gnn/layers/message_passing/message_passing.py,tf.shape
will be called redundantly in the iteration to get the same value, code here.Moreover, if users try to add
@tf.funtion
annotation to speed up this function in graph mode, lots of same nodes will be created in computation graph.Thus, I think
tf.shape
should be called only once before the loop.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
The text was updated successfully, but these errors were encountered: