Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in tf2_gnn/layers/message_passing/message_passing.py #50

Open
JamesCao2048 opened this issue Aug 2, 2021 · 0 comments

Comments

@JamesCao2048
Copy link

Hello,
I found that in the function calculate_type_to_num_incoming_edges, tf2_gnn/layers/message_passing/message_passing.py, tf.shapewill be called redundantly in the iteration to get the same value, code here.
Moreover, if users try to add @tf.funtion annotation to speed up this function in graph mode, lots of same nodes will be created in computation graph.
Thus, I think tf.shape should be called only once before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant