Encapsulate the background image settings into a JSON object #866
Labels
Area-Settings
Issues related to settings and customizability, for console or terminal
Issue-Task
It's a feature request, but it doesn't really need a major design.
Product-Terminal
The new Windows Terminal.
Milestone
Summary of the new feature/enhancement
As we're adding more settings to the JSON file, do we want to keep what's in each object flat or should we start introducing nested objects? I think having them be nested looks nicer and is easier to read (especially as the settings file gets really big). On the other hand, this might mean that we're forcing settings to look a certain way.
Consider this:
I think the proposal looks a lot nicer. I'm picking on backgroundImage from #853 but it definitely can apply to some other things like
fontProperties
(size, family, etc...) anddevEnvironment
(environmentVariables, startingDirectory, etc...).Also, I think it's easier to see the benefit when there's a nasty looking settings file as follows:
The text was updated successfully, but these errors were encountered: