Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazygit #8236

Closed
xaotag opened this issue Nov 12, 2020 · 4 comments
Closed

lazygit #8236

xaotag opened this issue Nov 12, 2020 · 4 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase Tracking-External This bug isn't resolved, but it's following an external workitem.

Comments

@xaotag
Copy link

xaotag commented Nov 12, 2020

terminal
image
powershell
image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 12, 2020
@j4james
Copy link
Collaborator

j4james commented Nov 12, 2020

I think this is a known issue in lazygit, which doesn't fully support full-width characters (see jesseduffield/lazygit#24). Apparently the problem was partially fixed in PR 231, so upgrading lazygit may help if you're using an old version.

In your PowerShell screenshot there aren't any Chinese characters visible, which is probably why you aren't seeing the issue there. It would be useful for comparison purposes if you could show the exact same diff in both Windows Terminal and PowerShell.

It would also be useful if you said which version of Windows Terminal you're using as well as the version of lazygit that you're using.

@xaotag
Copy link
Author

xaotag commented Nov 12, 2020

如果你使用旧版本，升
look
image

@zadjii-msft
Copy link
Member

Alright so this sounds like it's an external issue with lazygit, thanks for digging up the upstream issue @j4james!

@zadjii-msft zadjii-msft added Resolution-External For issues that are outside this codebase Tracking-External This bug isn't resolved, but it's following an external workitem. labels Nov 12, 2020
@xaotag
Copy link
Author

xaotag commented Nov 14, 2020

in the cmd
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@j4james @zadjii-msft @xaotag