Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding property to background image #6578

Closed
jt-github opened this issue Jun 18, 2020 · 3 comments
Closed

Add padding property to background image #6578

jt-github opened this issue Jun 18, 2020 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@jt-github
Copy link

jt-github commented Jun 18, 2020

For those of us that like to have a little icon as a background to help remind us of which tab we're in, the backgroundImage, backgroundImageAlignment (I prefer topRight), and backgroundImageStretchMode (I prefer none) are perfect. That sort of thing is usually desirable for images that fill up the whole pane, but smaller images that live somewhere other than the center of the pane are forced to slam up against the edges.

I propose a new property to allow adding a little space between the image and the edges of the pane:
backgroundImagePadding

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 18, 2020
@DHowett
Copy link
Member

DHowett commented Jun 18, 2020

Thanks for the request! This sounds like a /duplicate of #2620 to me, so I'm gonna close it out. I think this use case would totally be subsumed by offsetX/offsetY 😄

@ghost
Copy link

ghost commented Jun 18, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 18, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 18, 2020
@jt-github
Copy link
Author

Thanks for the quick action and for finding that this is a duplicate, @DHowett, and yes, the offsets would handle this nicely.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants