Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The size of the viewport margins (gutters) isn't uniform after a resize #15903

Closed
lhecker opened this issue Aug 30, 2023 · 4 comments
Closed

The size of the viewport margins (gutters) isn't uniform after a resize #15903

lhecker opened this issue Aug 30, 2023 · 4 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@lhecker
Copy link
Member

lhecker commented Aug 30, 2023 •
edited
Loading

Windows Terminal version

1.19.2412.0

Steps to reproduce:

Resize the window.

Actual Behavior

It's fairly self-explanatory:

image
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Aug 30, 2023
@lhecker lhecker changed the title The size of the viewport margins (gutters) isn't uniform The size of the viewport margins (gutters) isn't uniform after a resize Aug 30, 2023
@lhecker lhecker mentioned this issue Aug 30, 2023
Closed
@zadjii-msft
Copy link
Member

I don't think it ever has been...? Unless you have the snap to grid setting on

@lhecker
Copy link
Member Author

lhecker commented Aug 30, 2023 •
edited
Loading

But snap-to-grid is on by default, right?

re: "I don't think it ever has been...?"
When you launch Windows Terminal the margins are all uniform. Here's a 50x15 window with Ctrl+Shift+A:
image

After resizing the window to 51x15:
image

I don't think that's intentional. 😅

@zadjii
Copy link

zadjii commented Aug 30, 2023

#4175 maybe

@lhecker
Copy link
Member Author

lhecker commented Aug 30, 2023

Ah, damn I knew I saw an issue for that, but couldn't find it when searching for "gutters" or "margins".
BTW on 96 DPI displays the margins are also not uniform, just in a different way... The right one is off by 1-2px after launch and only correct after a resize.

@lhecker lhecker closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zadjii @lhecker @zadjii-msft