Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[megathread] Cursor shapes in WT UI / conhost UI / VT #15746

Open
1 of 3 tasks
alabuzhev opened this issue Jul 22, 2023 · 3 comments
Open
1 of 3 tasks

[megathread] Cursor shapes in WT UI / conhost UI / VT #15746

alabuzhev opened this issue Jul 22, 2023 · 3 comments
Labels
Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.

Comments

@alabuzhev
Copy link
Contributor

alabuzhev commented Jul 22, 2023 •
edited by zadjii-msft
Loading

Description of the new feature/enhancement

There are so many of them, and all the sets are slightly different:

WT:
image

Conhost:
image

VT:
image

There are quite a few inconsistencies:

  1. Terminology:
    • vintage / legacy
    • underscore / underline
    • bar / vertical bar
    • solid box / filled box / block
  2. UI order.
  3. Feature set: conhost does not have "double underscore"
  4. VT access: "vintage", "double underscore" and "empty box" are not exposed and cannot be set programmatically.
  5. UI access: non-blinking versions are not exposed.
  6. API behavior:
    • SetConsoleCursorInfo resets cursor to "legacy" in conhost if the size is different from the initial one, but not in WT (I understand why, but still).

I'm not saying that all those are bugs that should be fixed, but perhaps the situation could be improved.

maintainer tracking space

Tasks
Beta Give feedback
  1. Add doubleUnderscore cursor style #7827
    Area-Rendering Area-Settings AutoMerge Issue-Task Product-Terminal
    DHowett rhorber
  2. "vintage" cursor shape + blinking with an escape sequence? #7382
    Area-VT Product-Conhost
  3. Add support for turning off cursor blink #1379
    Area-TerminalControl Help Wanted Priority-2
@alabuzhev alabuzhev added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 22, 2023
@j4james
Copy link
Collaborator

j4james commented Jul 22, 2023

The "double underscore" cursor was a user contributed feature (PR #7827), and I don't think something like that is generally expected to be ported to conhost as well. Although it doesn't seem like it would require much more work - the GDI support was already done as far as I can see.

Extending the DECSCUSR sequence to support non-standard cursor styles is tracked in #7382.

Adding a UI setting to control the cursor blinking in WT is tracked in #1379.

Getting SetConsoleCursorInfo to work on WT the same as it does in conhost is also essentially covered by #7382 I think.

@zadjii-msft
Copy link
Member

That does seem like a pretty comprehensive answer. Anything missed/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 24, 2023
@zadjii-msft zadjii-msft added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 24, 2023
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Scenario and removed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 24, 2023
@zadjii-msft zadjii-msft changed the title Cursor shapes in WT UI / conhost UI / VT [megathread] Cursor shapes in WT UI / conhost UI / VT Jul 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 24, 2023
@zadjii-msft zadjii-msft added Product-Meta The product is the management of the products. and removed Product-Terminal The new Windows Terminal. Needs-Tag-Fix Doesn't match tag requirements labels Jul 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 24, 2023
@zadjii-msft
Copy link
Member

(we're gonna leave this open because it's a pretty good megathread for tracking purposes. Thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@j4james @alabuzhev @zadjii-msft