Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I scroll down or up the wheel, some lines will disappear #15330

Closed
Cricle opened this issue May 11, 2023 · 5 comments
Closed

When I scroll down or up the wheel, some lines will disappear #15330

Cricle opened this issue May 11, 2023 · 5 comments
Assignees
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Cricle
Copy link

Cricle commented May 11, 2023

Windows Terminal version

1.16.10261.0

Windows build number

10.0.19045.0

Other Software

None

Steps to reproduce

  1. Run other program, generate many lines of content(Like benchmark)
  2. Scroll down or up the wheel(The disappearing row must be moved to an invisible area before it can be seen again)
  3. Some lines will disappear

image

Expected Behavior

Some lines will disappear

Actual Behavior

Nothing to do

@Cricle Cricle added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 11, 2023
@lhecker
Copy link
Member

lhecker commented May 16, 2023

Reading nushell/nushell#9166 it does seem a little unclear to me whether this is a bug in Windows Terminal, nushell or starship. I do know however that this is easily reproducible with starship because I had this issue myself before, but I simply assumed that this is a bug in starship.

Reading through the various, linked issues however, I think this might be due to #8698.

@j4james
Copy link
Collaborator

j4james commented May 18, 2023

@lhecker If they're using an SU sequence to scroll (which is the impression I got from your comments on the nushell issue), then this is potentially a dup of #11078.

If the SU is triggered by a terminfo indn command, it's kind of our problem, because we're identifying as xterm-256color, which defines indn as an SU sequence (that's what #11078 is all about). But if they're invoking SU directly, then I'd say it's more their problem, because they're relying on an interpretation of SU which isn't standard.

@lhecker
Copy link
Member

lhecker commented May 18, 2023

Thank you for looking into this! As you probably already saw they’re invoking it directly. I personally agree with everything you said in #11078 btw - I feel like we should make that change irregardless of the ambiguity of the sequence and that it should best be avoided, if not at least because of indn.

@zadjii-msft
Copy link
Member

That lines up with the theory we were discussing in triage yesterday. I'll tentatively call this a dupe, with the note that Leonard did have a live repro of this, so it should be fairly easy to validate if the fix for #11078 fixes this.

/dup #11078

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants