Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Background Image Padding setting option #12771

Closed
Dominik-H opened this issue Mar 27, 2022 · 2 comments
Closed

Feature Request: Background Image Padding setting option #12771

Dominik-H opened this issue Mar 27, 2022 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Dominik-H
Copy link

Description of the new feature/enhancement

I propose adding an option to set padding for background image in settings. While "backgroundImageAlignment" is awesome and works fine for basic image placement adding an option for user to pad their image by requested amount of pixels would allow the user to place the image in any spot in the terminal window.

I am NOT proposing removal of backgroundImageAlignment but an extension option to add padding to image position.

Proposed technical implementation details (optional)

Of course this is up to the implementation team but my proposal is to add parameter similar to the "padding" that positions the text in the terminal.

  • Name of the parameter could be "backgroundImagePadding"
  • It would accept similar options as mentioned "padding" parameter: "#", "#, #" and "#, #, #, #"
  • Default value would be "0, 0, 0, 0"
  • When both "backgroundImageAlignment" parameter and new "backgroundImagePadding" are set, the Alignment position would be taken as origin and added to the padding values which would yield new position of the image e.g.: "bottomRight" option is bottom right corner and together with padding of "0, 10, 0, 10" it would calculate position offseting the image by 10 pixels from bottom right corner in both directions.
@Dominik-H Dominik-H added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 27, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 27, 2022
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #2620 for more discussion.

/dup #2620

@ghost
Copy link

ghost commented Apr 11, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants