Skip to content

Commit 61ae3a7

Browse files
committed
quick push it finally works right!
1 parent 3439f0b commit 61ae3a7

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

src/cascadia/TerminalApp/SuggestionsControl.cpp

+16-15
Original file line numberDiff line numberDiff line change
@@ -1256,22 +1256,23 @@ namespace winrt::TerminalApp::implementation
12561256

12571257
// Create a thickness for the new margins
12581258
auto newMargin = Windows::UI::Xaml::ThicknessHelper::FromLengths(clampedX, 0, 0, 0);
1259-
// Now, position vertically.
1260-
if (_direction == TerminalApp::SuggestionsDirection::TopDown)
1261-
{
1262-
// The control should open right below the cursor, with the list
1263-
// extending below. This is easy, we can just use the cursor as the
1264-
// origin (more or less)
1265-
newMargin.Top = (_anchor.Y /* - descriptionSize.height*/);
1266-
}
1267-
else
1268-
{
1269-
// Position at the cursor. The suggestions UI itself will maintain
1270-
// its own offset such that it's always above its origin
1271-
// NO newMargin.Top = (_anchor.Y - actualSize.height /* - descriptionSize.height*/);
1272-
newMargin.Top = (_anchor.Y - actualSize.height - descriptionSize.height);
1273-
}
1259+
// // Now, position vertically.
1260+
// if (_direction == TerminalApp::SuggestionsDirection::TopDown)
1261+
// {
1262+
// // The control should open right below the cursor, with the list
1263+
// // extending below. This is easy, we can just use the cursor as the
1264+
// // origin (more or less)
1265+
// newMargin.Top = (_anchor.Y /* - descriptionSize.height*/);
1266+
// }
1267+
// else
1268+
// {
1269+
// // Position at the cursor. The suggestions UI itself will maintain
1270+
// // its own offset such that it's always above its origin
1271+
// // NO newMargin.Top = (_anchor.Y - actualSize.height /* - descriptionSize.height*/);
1272+
// newMargin.Top = (_anchor.Y - actualSize.height - descriptionSize.height);
1273+
// }
12741274
Margin(newMargin);
1275+
_recalculateTopMargin();
12751276

12761277
_searchBox().Text(filter);
12771278

0 commit comments

Comments
 (0)