Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Redis Memory Connector should be able to take existing redis connection, not just connection string #6084

Closed
engt21 opened this issue May 1, 2024 · 3 comments
Labels
enhancement python Pull requests for the Python Semantic Kernel stale Issue is stale because it has been open for 90 days with no activity

Comments

@engt21
Copy link

engt21 commented May 1, 2024

Python redis memory connector should be able to take an existing redis connection. For example, some enterprises require/have other methodologies to connect to redis beyond the default connection string and those connections require additional parameters that cannot work with the default connection string.

Since connecting via the connection string also returns a redis.Redis object and sets it to the memory connector's database attribute, passing in an existing redis connector to set to that attribute should also work.

Have already discussed this briefly with a member of the team.

I will provide the implementation/fix that worked in my enterprise in PR.

@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels May 1, 2024
@engt21
Copy link
Author

engt21 commented May 1, 2024

Please let me know if/when/what next steps are before I can raise a PR. Thanks!

@engt21 engt21 changed the title Python Redis Memory Connector takes existing redis connection Python Redis Memory Connector should be able to take existing redis connection, not just connection string May 1, 2024
Copy link

github-actions bot commented Aug 6, 2024

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Issue is stale because it has been open for 90 days with no activity label Aug 6, 2024
@moonbox3
Copy link
Contributor

As of SK Python 1.5.0 the redis_store supports creating the object with an existing Redis database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Pull requests for the Python Semantic Kernel stale Issue is stale because it has been open for 90 days with no activity
Projects
None yet
Development

No branches or pull requests

4 participants