Internal Content is not properly displayed

[jnix-abk]

I'm trying to get internal content to display in VS code and the code that prepares the artifact locations does not align with the code that consumes the artifact location.

sarif-vscode-extension/src/shared/index.ts

Lines 193 to 200 in a1740e7

	// A shorter more transparent URI format would be:
	// `sarif://${encodeURIComponent(result._log._uri)}/${result._run._index}/${anyArtLoc.index}/${uri?.file ?? 'Untitled'}`
	// However between workspace.openTextDocument() and registerTextDocumentContentProvider/provideTextDocumentContent()
	// VS Code fails to maintain the authority value (possibly due to an encoding bug).
	const uriContents = runArtCon?.text || runArtCon?.binary
	? encodeURI(`sarif:${encodeURIComponent(result._log._uri)}/${result._run._index}/${anyArtLoc.index}/${uri?.file ?? 'Untitled'}`)
	: undefined;
	return [uri, uriBase, uriContents];

Notice that Line 194 refers to links as sarif:// and Line 198 refers to them as sarif:. This causes the consuming code to not recognize internal references (which are required to be sarif://):

sarif-vscode-extension/src/extension/uriRebaser.ts

Lines 116 to 117 in a1740e7

	// Sarif-scheme URIs are owned/created by us, so we know they exist.
	if (artifactUri.startsWith('sarif://')) return Uri.parse(artifactUri, true);

The Virtual Document handler expects the links to be sarif: otherwise the extra forward slashes break the link parsing.

sarif-vscode-extension/src/extension/index.ts

Lines 276 to 278 in a1740e7

	disposables.push(workspace.registerTextDocumentContentProvider('sarif', {
	provideTextDocumentContent: (uri, token) => {
	const [logUriEncoded, runIndex, artifactIndex] = uri.path.split('/');

Debugging this myself, I altered Line 117 in uriRebaser.ts to check just for sarif:. I am not sure if this is the correct fix, but I was able to embed content and have it work.