Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-formatter-sarif "suppressions" can include duplicate items that causes sarif uploading issues #86

Closed
martgil opened this issue May 26, 2024 · 0 comments

Comments

@martgil
Copy link

martgil commented May 26, 2024

Hello Team,

I'd like to report an issue when the eslint-formatter-sarif suppressions can include duplicate items from which uploading sarif files to fail.

Error we received on https://github.com/FlowCrypt/flowcrypt-browser/actions/runs/9240112388/job/25420029132:

image

Rrror in plain text:
Run github/codeql-action/upload-sarif@v3
Uploading results
Error details: instance.runs[0].results[[8](https://github.com/FlowCrypt/flowcrypt-browser/actions/runs/9240112388/job/25420029132#step:6:9)01].suppressions contains duplicate item
Error details: instance.runs[0].results[803].suppressions contains duplicate item
Error details: instance.runs[0].results[805].suppressions contains duplicate item
Error: Unable to upload "eslint-results.sarif" as it is not valid SARIF:
- instance.runs[0].results[801].suppressions contains duplicate item
- instance.runs[0].results[803].suppressions contains duplicate item
- instance.runs[0].results[805].suppressions contains duplicate item
ConfigurationError: Unable to upload "eslint-results.sarif" as it is not valid SARIF:
- instance.runs[0].results[801].suppressions contains duplicate item
- instance.runs[0].results[803].suppressions contains duplicate item
- instance.runs[0].results[805].suppressions contains duplicate item
    at run (/home/runner/work/_actions/github/codeql-action/v3/lib/upload-sarif-action.js:70:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v3/lib/upload-sarif-action.js:84:9)

So for us to proceed into fixing the issue temporarily on our side, we'll have to update the code for populating the suppressions - FlowCrypt/flowcrypt-browser@876c442#diff-309b09cf37242b8d5d9b63644d18bb3b386d6dc257ea0be89f3fff0e61718979R196-R216

Other than this, the formatter is working so well. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant