Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-patch] The bulk suppressions feature should report bulk suppressed problems as "suppressed" #5054

Open
dmichon-msft opened this issue Dec 18, 2024 · 0 comments · May be fixed by #5055

Comments

@dmichon-msft
Copy link
Contributor

Summary

The linter outputs messages and suppressedMessages. Currently issues suppressed by eslint-bulk-suppressions show up in neither. Issues suppressed by //eslint-disable* directives show up in suppressedMessages.
This is relevant because when generating audit reports, the set of suppressedMessages are relevant.

Repro steps

Inspect the suppressedMessages field of the linter results via debugger in a project with eslint-bulk-suppressions configured and suppressing problems.

Expected result:
The lint problems being suppressed by eslint-bulk-suppressions should be present in suppressedMessages, with some explanation indicating that they were suppressed by the eslint-bulk-suppressions feature.

Actual result:
The lint problems being suppressed by eslint-bulk-suppressions are not visible at all.

Details

This is a consequence of the eslint-bulk-suppressions feature omitting problems from the output entirely, instead of setting the problem.suppression field.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
Package name: @rushstack/eslint-patch
Package version? 1.10.4
Operating system? Linux
Would you consider contributing a PR? Yes
Node.js version (node -v)? 18.19.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging a pull request may close this issue.

1 participant