-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] unexpected version string with pnpm v9? #5047
Comments
@fzxen any insights? |
This seems to be the behavior of pnpm. Pnpm will add a suffix related to peerDependencies in the version field. import dp from '@pnpm/dependency-path';
const versionString = "file:projects/abort-controller.tgz([email protected](@types/[email protected])([email protected])([email protected](@types/[email protected]))"
dp.removeSuffix(versionString) // 'file:projects/abort-controller.tgz' |
@fzxen is it expected for the version string to only contains this part (no suffix)?
|
@jeremymeng Both of these version strings are as expected. The suffix is added when the dependency has peer dependencies. |
After upgrading to pnpm v9, we found that some version strings look strange. There are two version formats for non-workspace projects in our mono repo under importers/dependencies:
https://github.com/Azure/azure-sdk-for-js/blob/050adc297757b27e2344498a653042f58739d884/common/config/rush/pnpm-lock.yaml#L13-L15
and
https://github.com/Azure/azure-sdk-for-js/blob/050adc297757b27e2344498a653042f58739d884/common/config/rush/pnpm-lock.yaml#L424-L426
while
rush update/install
etc. are working fine. At least the second version string format is not considered valid by some of our internal tools.The text was updated successfully, but these errors were encountered: