Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] rush-pnpm outdated does not work #5035

Open
kaiyoma opened this issue Dec 6, 2024 · 4 comments
Open

[rush] rush-pnpm outdated does not work #5035

kaiyoma opened this issue Dec 6, 2024 · 4 comments
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@kaiyoma
Copy link

kaiyoma commented Dec 6, 2024

Summary

rush-pnpm outdated does not work (prints nothing).

Repro steps

Run rush-pnpm outdated.

Expected result: Outdated dependencies

Actual result: Crickets

Details

As noted elsewhere, pnpm outdated -r -C common/temp does work, but this requires us to have pnpm installed globally. Ideally, we should be using rush for everything, and Rush should be managing pnpm for us and shielding us from that.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.131.5
rushVersion from rush.json? 5.131.5
useWorkspaces from rush.json? N/A
Operating system? Any
Would you consider contributing a PR? No
Node.js version (node -v)? 20.11.1
@iclanton
Copy link
Member

iclanton commented Dec 9, 2024

I'm getting this error:

 ERR_PNPM_NO_IMPORTER_MANIFEST_FOUND  No package.json (or package.yaml, or package.json5) was found in "<repo root path>".

Looks like it may not be running in the right folder. It probably expects to run with a cwd of <repo root>/common/temp. Probably an easy fix.

@iclanton iclanton moved this from Needs triage to Low priority in Bug Triage Dec 9, 2024
@iclanton iclanton added bug Something isn't working as intended help wanted If you're looking to contribute, this issue is a good place to start! effort: easy Probably a quick fix. Want to contribute? :-) labels Dec 9, 2024
@kaiyoma
Copy link
Author

kaiyoma commented Dec 11, 2024

Looks like it may not be running in the right folder. It probably expects to run with a cwd of <repo root>/common/temp. Probably an easy fix.

This same approach might also fix rush-pnpm why which is similarly broken and similarly needs to run in the right directory context.

@dmichon-msft
Copy link
Contributor

rush-pnpm doesn't automatically inject the -r flag, so you have to run rush-pnpm outdated -r or rush-pnpm why -r for it to work properly.

@kaiyoma
Copy link
Author

kaiyoma commented Dec 12, 2024

rush-pnpm doesn't automatically inject the -r flag, so you have to run rush-pnpm outdated -r or rush-pnpm why -r for it to work properly.

Oh wow, I can't believe the solution was this simple all along. Thank you!

Do you think the -r flag should be automatically applied to these commands? If not, what about some kind of error output about the missing flag? Having the tool print nothing feels like the worst of all worlds here, since it leads to a lot of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Status: Low priority
Development

No branches or pull requests

3 participants