Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] shrinkwrapIsUpToDate does not take globalOverrides into account #4820

Closed
fzxen opened this issue Jun 28, 2024 · 2 comments · Fixed by #4898
Closed

[rush] shrinkwrapIsUpToDate does not take globalOverrides into account #4820

fzxen opened this issue Jun 28, 2024 · 2 comments · Fixed by #4898

Comments

@fzxen
Copy link
Contributor

fzxen commented Jun 28, 2024

Summary

After I modified the globalOverrides field in common/config/rush/pnpm-config.json, I hope rush can remind me to execute rush update to update lockfile. However, I didn't encounter any errors when I executed rush install. And lockfile also did not be updated.

Repro steps

  1. modify the globalOverrides field in common/config/rush/pnpm-config.json
  2. run rush install in workspace.

Expected result:

Rush should throw an error and remind me: The shrinkwrap file is out of date. You need to run "rush update".

Actual result:

Install successfully. There are no changes about git tracked files in our repo, but the common/temp/pnpm-lock.yaml has indeed been updated.

Actually, The lockfile was not updated even after I executed the rush update. Only after executing rush update --recheck will the lockfile be updated correctly.

Details

I guess the logic of judging whether shrinkwraps is updated does not take globalOverrides into account and not sure whether this is intentional.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.129.6
rushVersion from rush.json? 5.129.6
useWorkspaces from rush.json? true
Operating system? Mac
Would you consider contributing a PR?
Node.js version (node -v)? v16.20.2
@iclanton
Copy link
Member

iclanton commented Jul 1, 2024

Looks like we need to ensure the packageExtensionsChecksum is up-to-date.

Would you be interested in contributing this fix?

@iclanton iclanton moved this from Needs triage to Needs Investigation in Bug Triage Jul 1, 2024
@fzxen
Copy link
Contributor Author

fzxen commented Jul 2, 2024

@iclanton OK, I will take a look at the relevant implementations in rush and try to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants