You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
node-sass is deprecated and no additional sass feature will come.
Details
node-sass (and libsass) used by heft-sass-plugin has been deprecated and is not compatible with the new css or sass feature. The same kind of PR #1666 was resolved before, but it seems that the code using node-sass is restored when refactoring the rushstack-legacy.
There are 3 sass implementation available for now.
node-sass: Deprecated. many sass features still are available but nothing new will come.
dart-sass(sass): It's known as having some performance overhead because it is pure javascript version converted from dart-sass. If the changing log I'd saw is correct one, rushstack-legacy was choose node-sass because of performance issue. the compilation performance might be critical especially for large scaled codebase. so this decision should be respected also.
sass-embedded: This is javascript wrapper around a native dart executable. Because of it depends Dart, It will be much faster especially for large sass compilations generally, but also have relatively limited platform supports which can install Dart runtime. (Windows, MacOS and Linux)
sass-embedded seems suitable for most users but none of options are perfect.
So maybe giving configurable option is the simpliest and ideal.
Or, We can provide heft-dart-sass-plugin or heft-sass-embedded-plugin like we did for webpack5.
I agree that the scalability issue with dart-sass could be an eventual problem but I believe having the option for sass-embedded is a good plug-n-play solution here.
Summary
node-sass is deprecated and no additional sass feature will come.
Details
node-sass (and libsass) used by heft-sass-plugin has been deprecated and is not compatible with the new css or sass feature. The same kind of PR #1666 was resolved before, but it seems that the code using node-sass is restored when refactoring the rushstack-legacy.
There are 3 sass implementation available for now.
sass-embedded seems suitable for most users but none of options are perfect.
So maybe giving configurable option is the simpliest and ideal.
Or, We can provide
heft-dart-sass-plugin
orheft-sass-embedded-plugin
like we did for webpack5.Related
Sass plugin should allow to configure the sass transpiler.
[heft] SassPlugin Refactor & Improvements #2732 by @halfnibbleAdds sass implementation option on heft-sass-plugin
chat room by @csobjThe text was updated successfully, but these errors were encountered: