From 99bf4f9de835b1e7d5648501540f59868d6c0a30 Mon Sep 17 00:00:00 2001 From: Your Name Date: Sat, 3 Jan 2026 21:52:26 +0530 Subject: [PATCH 1/3] fix(telemetry): prevent blank resultCode in command events --- .../telemetry/src/telemetry.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/@react-native-windows/telemetry/src/telemetry.ts b/packages/@react-native-windows/telemetry/src/telemetry.ts index 5da0170d06a..1edd9245c4b 100644 --- a/packages/@react-native-windows/telemetry/src/telemetry.ts +++ b/packages/@react-native-windows/telemetry/src/telemetry.ts @@ -5,7 +5,7 @@ */ import * as coreOneDS from '@microsoft/1ds-core-js'; -import {PostChannel, IChannelConfiguration} from '@microsoft/1ds-post-js'; +import { PostChannel, IChannelConfiguration } from '@microsoft/1ds-post-js'; import * as basePropUtils from './utils/basePropUtils'; import * as versionUtils from './utils/versionUtils'; @@ -100,7 +100,7 @@ export class Telemetry { | projectUtils.DependencyProjectInfo = undefined; // Store "Common Properties" in a single object. This will be logged in all telemetry events. - protected static commonProperties: {[key: string]: string} = {}; + protected static commonProperties: { [key: string]: string } = {}; protected static getDefaultSetupString(): string { // Enable overriding the default setup string via an environment variable @@ -406,7 +406,7 @@ export class Telemetry { } private static trackCommandEvent(extraProps?: Record) { - const telemetryItem: coreOneDS.ITelemetryItem = {name: CommandEventName}; + const telemetryItem: coreOneDS.ITelemetryItem = { name: CommandEventName }; // This is logged in Part C. const command = { @@ -414,9 +414,9 @@ export class Telemetry { defaultOptions: Telemetry.commandInfo.startInfo?.defaultOptions, args: Telemetry.commandInfo.startInfo?.args, durationInSecs: - (Telemetry.commandInfo.endTime! - Telemetry.commandInfo.startTime!) / - 1000, - resultCode: Telemetry.commandInfo.endInfo?.resultCode, + (Telemetry.commandInfo.endTime! - Telemetry.commandInfo.startTime!) / 1000, + resultCode: + Telemetry.commandInfo.endInfo?.resultCode ?? 'Unknown', }; telemetryItem.data = { @@ -436,7 +436,7 @@ export class Telemetry { return; } - const telemetryItem: coreOneDS.ITelemetryItem = {name: CodedErrorEventName}; + const telemetryItem: coreOneDS.ITelemetryItem = { name: CodedErrorEventName }; // Save off CodedError info in Part C. const codedError = From 423f00f2a315ab374e09e02d381e600fd43e66d6 Mon Sep 17 00:00:00 2001 From: Your Name Date: Wed, 7 Jan 2026 12:35:48 +0530 Subject: [PATCH 2/3] Change files --- ...ows-telemetry-b700f162-eba7-42c7-a8bd-b2d69c628c16.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@react-native-windows-telemetry-b700f162-eba7-42c7-a8bd-b2d69c628c16.json diff --git a/change/@react-native-windows-telemetry-b700f162-eba7-42c7-a8bd-b2d69c628c16.json b/change/@react-native-windows-telemetry-b700f162-eba7-42c7-a8bd-b2d69c628c16.json new file mode 100644 index 00000000000..9e5207469cc --- /dev/null +++ b/change/@react-native-windows-telemetry-b700f162-eba7-42c7-a8bd-b2d69c628c16.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "fix(telemetry): prevent blank resultCode in command events", + "packageName": "@react-native-windows/telemetry", + "email": "raykar.s2504@gmail.com", + "dependentChangeType": "patch" +} From 5b4846ed342dcdf5849db2652c99f033e9b37939 Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 8 Jan 2026 12:48:54 +0530 Subject: [PATCH 3/3] chore(telemetry): fix prettier formatting --- .../telemetry/src/telemetry.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/@react-native-windows/telemetry/src/telemetry.ts b/packages/@react-native-windows/telemetry/src/telemetry.ts index 1edd9245c4b..722cec7b0a5 100644 --- a/packages/@react-native-windows/telemetry/src/telemetry.ts +++ b/packages/@react-native-windows/telemetry/src/telemetry.ts @@ -5,7 +5,7 @@ */ import * as coreOneDS from '@microsoft/1ds-core-js'; -import { PostChannel, IChannelConfiguration } from '@microsoft/1ds-post-js'; +import {PostChannel, IChannelConfiguration} from '@microsoft/1ds-post-js'; import * as basePropUtils from './utils/basePropUtils'; import * as versionUtils from './utils/versionUtils'; @@ -100,7 +100,7 @@ export class Telemetry { | projectUtils.DependencyProjectInfo = undefined; // Store "Common Properties" in a single object. This will be logged in all telemetry events. - protected static commonProperties: { [key: string]: string } = {}; + protected static commonProperties: {[key: string]: string} = {}; protected static getDefaultSetupString(): string { // Enable overriding the default setup string via an environment variable @@ -406,7 +406,7 @@ export class Telemetry { } private static trackCommandEvent(extraProps?: Record) { - const telemetryItem: coreOneDS.ITelemetryItem = { name: CommandEventName }; + const telemetryItem: coreOneDS.ITelemetryItem = {name: CommandEventName}; // This is logged in Part C. const command = { @@ -414,9 +414,9 @@ export class Telemetry { defaultOptions: Telemetry.commandInfo.startInfo?.defaultOptions, args: Telemetry.commandInfo.startInfo?.args, durationInSecs: - (Telemetry.commandInfo.endTime! - Telemetry.commandInfo.startTime!) / 1000, - resultCode: - Telemetry.commandInfo.endInfo?.resultCode ?? 'Unknown', + (Telemetry.commandInfo.endTime! - Telemetry.commandInfo.startTime!) / + 1000, + resultCode: Telemetry.commandInfo.endInfo?.resultCode ?? 'Unknown', }; telemetryItem.data = { @@ -436,7 +436,7 @@ export class Telemetry { return; } - const telemetryItem: coreOneDS.ITelemetryItem = { name: CodedErrorEventName }; + const telemetryItem: coreOneDS.ITelemetryItem = {name: CodedErrorEventName}; // Save off CodedError info in Part C. const codedError =