From 30275047a683452546e830ac3c9985518040d197 Mon Sep 17 00:00:00 2001 From: Jon Thysell Date: Thu, 17 Aug 2023 11:17:57 -0700 Subject: [PATCH] [0.71] Fix BinSkim warnings for Desktop This PR backports #11816 to 0.71. BinSkim has been throwing warnings for Desktop ever since the upgrade to BinSkim@4. Particularly this is from scanning the Hermes and V8 dlls. However both are sourced from their own Microsoft-owned repos and only consumed here via published NuGets. BinSkim should be running on those repos (if required) not here in RNW. This PR updates the pipeline to only test the binaries built by this pipeline. --- .ado/jobs/desktop.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.ado/jobs/desktop.yml b/.ado/jobs/desktop.yml index 8adb4231e48..4e3479d8a63 100644 --- a/.ado/jobs/desktop.yml +++ b/.ado/jobs/desktop.yml @@ -188,11 +188,7 @@ jobs: InputType: 'Basic' Function: 'analyze' TargetPattern: 'guardianGlob' - # Scanning v8jsi.dll in x64/x86 only, because PDBs are stripped in ARM64 - ${{ if ne(matrix.BuildPlatform, 'ARM64') }}: - AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\*.dll' - ${{ else }}: - AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\react-native-win32.dll' + AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\React.Windows.Desktop.DLL\react-native-win32.dll' AnalyzeVerbose: true toolVersion: 'Latest' continueOnError: true