Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Community's Async Storage #2271

Closed
krizzu opened this issue Apr 9, 2019 · 3 comments · Fixed by react-native-async-storage/async-storage#327
Closed

Add support for Community's Async Storage #2271

krizzu opened this issue Apr 9, 2019 · 3 comments · Fixed by react-native-async-storage/async-storage#327
Assignees
@kaiguo
Labels
Deliverable Major item tracked for top-level planning in ADO Extensions Tracks issues against community modules and extensions must-have p1 Partner: Stream (label may be applied by bot based on author)
Milestone
0.62 (M5)

Comments

@krizzu
Copy link

krizzu commented Apr 9, 2019

Hello 👋

As part of Lean Core effort in React Native, some modules are extracted into external repos, under RN Community's org.

One of them is Async Storage, used in most of the apps. In order to deprecate old AS module, we've ditched NativeModule's name from AsyncLocalStorage to PlatformLocalStorage.

Currently, RN-windows uses deprecated name, so it'd be great to keep it in sync.

Let me know what you think.

thanks.
@krizzu krizzu added the rnwcpp label Apr 9, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 9, 2019
@krizzu krizzu mentioned this issue Apr 10, 2019
Merged
@harinikmsft harinikmsft added ready for dev and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 10, 2019
@chrisglein chrisglein added the Extensions Tracks issues against community modules and extensions label Aug 10, 2019
@chrisglein chrisglein changed the title Add support for Community's Async Storage [CPP] Add support for Community's Async Storage Aug 10, 2019
@chrisglein chrisglein added this to the vNext Milestone 4 milestone Aug 23, 2019
This was referenced Oct 14, 2019
Closed
Closed
This was referenced Oct 31, 2019
Closed
Closed
@chrisglein
Copy link
Member

Customer is currently unblocked. We have limited time for M4 (~1 month) so this will wait for the new year.

@chrisglein chrisglein mentioned this issue Feb 4, 2020
Closed
@robertev
Copy link

For my customer, this is a dependency for several different libraries for them. This is one that absolutely will be necessary for things like our offline data storage for Realm and Redux; token storage for Azure Auth; etc.

@chrisglein chrisglein mentioned this issue Feb 27, 2020
Closed
@chrisglein chrisglein added the Deliverable Major item tracked for top-level planning in ADO label Mar 5, 2020
@stmoy stmoy added the Partner: Stream (label may be applied by bot based on author) label Mar 6, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@kaiguo
Copy link
Contributor

kaiguo commented Apr 3, 2020

PR: react-native-async-storage/async-storage#324.

@kaiguo kaiguo mentioned this issue Apr 7, 2020
Merged
@chrisglein chrisglein mentioned this issue Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaiguo kaiguo

Labels
Deliverable Major item tracked for top-level planning in ADO Extensions Tracks issues against community modules and extensions must-have p1 Partner: Stream (label may be applied by bot based on author)
Projects
None yet
Milestone
0.62 (M5)
Development

Successfully merging a pull request may close this issue.

Add Windows AsyncStorage kaiguo/async-storage
6 participants
@kaiguo @krizzu @robertev @harinikmsft @stmoy @chrisglein