Skip to content

Commit b7b0ea9

Browse files
authored
[0.71] Fix BinSkim warnings for Desktop (#12041)
This PR backports #11816 to 0.71. BinSkim has been throwing warnings for Desktop ever since the upgrade to BinSkim@4. Particularly this is from scanning the Hermes and V8 dlls. However both are sourced from their own Microsoft-owned repos and only consumed here via published NuGets. BinSkim should be running on those repos (if required) not here in RNW. This PR updates the pipeline to only test the binaries built by this pipeline.
1 parent f8ab997 commit b7b0ea9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.ado/jobs/desktop.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,7 @@ jobs:
188188
InputType: 'Basic'
189189
Function: 'analyze'
190190
TargetPattern: 'guardianGlob'
191-
# Scanning v8jsi.dll in x64/x86 only, because PDBs are stripped in ARM64
192-
${{ if ne(matrix.BuildPlatform, 'ARM64') }}:
193-
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\*.dll'
194-
${{ else }}:
195-
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\\React.Windows.Desktop.DLL\react-native-win32.dll'
191+
AnalyzeTargetGlob: '$(Build.SourcesDirectory)\vnext\target\${{ matrix.BuildPlatform }}\${{ matrix.BuildConfiguration }}\React.Windows.Desktop.DLL\react-native-win32.dll'
196192
AnalyzeVerbose: true
197193
toolVersion: 'Latest'
198194
continueOnError: true

0 commit comments

Comments
 (0)