Move react menu to title bar #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase this? I've just merged #166 so the diff shouldn't be this big. |
|
Also, can you post a screenshot? 😄 |
AnastasiaOrishchenko
force-pushed
the
move-react-menu
branch
3 times, most recently
from
9fc4347 to
cc62100
Compare
added 11 commits
July 28, 2020 13:12
AnastasiaOrishchenko
force-pushed
the
move-react-menu
branch
from
cc62100 to
463798f
Compare
tido64
reviewed
Jul 28, 2020
|
It also looks like the title isn't perfectly centered. It looks like it is being pushed out by the menu bar. |
tido64
reviewed
Jul 28, 2020
tido64
approved these changes
Jul 29, 2020
AnastasiaOrishchenko
force-pushed
the
move-react-menu
branch
from
ea52100 to
6382ad1
Compare
|
Didn't find better solution to remove the gap between button and menu flyout than setting negative margin - can see if I find something better later. |
Sounds good to me. Merging. |
tido64
pushed a commit
that referenced
this pull request
Aug 27, 2020
tido64
pushed a commit
that referenced
this pull request
Aug 27, 2020
tido64
pushed a commit
that referenced
this pull request
Aug 27, 2020
tido64
pushed a commit
that referenced
this pull request
Aug 27, 2020
tido64
pushed a commit
that referenced
this pull request
Aug 27, 2020
tido64
pushed a commit
that referenced
this pull request
Aug 28, 2020
tido64
pushed a commit
that referenced
this pull request
Sep 4, 2020
tido64
pushed a commit
that referenced
this pull request
Sep 4, 2020
tido64
pushed a commit
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's how it looks like now: