Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: declare support for react-native-macos/-windows 0.73 #1752

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: declare support for react-native-macos/-windows 0.73 #1752

merged 1 commit into from
Jan 2, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 2, 2024 •
edited
Loading

Description

Declare support for react-native-macos/react-native-windows 0.73

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

macOS

npm run set-react-version 0.73
yarn
cd example
rm macos/Podfile.lock
pod install --project-directory=macos
yarn macos

# In a separate terminal:
yarn start

Windows

npm run set-react-version 0.73
yarn
cd example
yarn install-windows-test-app
yarn windows

# In a separate terminal:
yarn start

Screenshots

macOS Windows
macOS Windows

@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Jan 2, 2024
@tido64 tido64 mentioned this pull request Jan 2, 2024
Merged
8 tasks
@tido64 tido64 requested review from kelset and Saadnajmi January 2, 2024 10:24
@tido64 tido64 marked this pull request as ready for review January 2, 2024 10:25
kelset
kelset approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tido64 tido64 merged commit 88822da into trunk Jan 2, 2024
27 checks passed
@tido64 tido64 deleted the tido/desktop-0.73 branch January 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi Saadnajmi is a code owner

Assignees
No one assigned
Labels
platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @kelset