From a233d8b60fcde89ed7208ee2bf685de9701389f1 Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Fri, 17 Dec 2021 19:52:05 +0100 Subject: [PATCH] fix(android): contain use of JCenter to 0.64 and older (#658) --- android/app/build.gradle | 21 ++++++++++++--------- android/test-app-util.gradle | 8 ++++++++ 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index fb6a1ecb6..ad8b00fc4 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -25,15 +25,18 @@ repositories { mavenCentral() google() - // TODO: Remove these when they've been published to Maven Central. - // See https://github.com/microsoft/react-native-test-app/issues/305 - // noinspection JcenterRepositoryObsolete - jcenter() { - content { - includeGroup("com.facebook.fbjni") - includeGroup("com.facebook.flipper") - includeGroup("com.facebook.fresco") - includeGroup("com.facebook.yoga") + // TODO: Remove this block when we drop support for 0.64. + if (getReactNativeVersionNumber(rootDir) < 6500) { + // Artifacts for 0.65+ are published to Maven Central. If we're on an + // older version, we still need to use JCenter. + // noinspection JcenterRepositoryObsolete + jcenter() { + content { + includeGroup("com.facebook.fbjni") + includeGroup("com.facebook.flipper") + includeGroup("com.facebook.fresco") + includeGroup("com.facebook.yoga") + } } } diff --git a/android/test-app-util.gradle b/android/test-app-util.gradle index 7cb7458d9..0ec24cc47 100644 --- a/android/test-app-util.gradle +++ b/android/test-app-util.gradle @@ -137,3 +137,11 @@ ext.getFlipperVersion = { baseDir -> // Use the recommended Flipper version return recommendedFlipperVersion } + +ext.getReactNativeVersionNumber = { baseDir -> + def reactNativePath = findNodeModulesPath(baseDir, "react-native") + def packageJson = file("${reactNativePath}/package.json") + def manifest = new JsonSlurper().parseText(packageJson.text) + def (major, minor, patch) = manifest["version"].tokenize(".") + return (major as int) * 10000 + (minor as int) * 100 + (patch as int) +}