Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of minor fixes in NativeToJsBridge #151

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

mganandraj
Copy link

@mganandraj mganandraj commented Aug 28, 2019

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Description of changes

These changes will windows builds with systrace turned on. It contains two changes,

  1. The change in NativeToJsBridge.cpp removes a statement that we added over the FB's change last year. In other words, it is removing an existing difference.
  2. The change in NativeToJsBridge.h fixes a non-standard c++ statement. I've raised a PR in FB repo too : fixing ATOMIC_VAR_INIT call facebook/react-native#26238

Focus areas to test

Build validation should suffice.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@tudorms tudorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pull-bot
Copy link

Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS against 61775be

@mganandraj mganandraj merged commit de6f5ed into microsoft:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants