Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.66] Flatlist keyboard navigation: Mouse can move selection #1269

Merged
merged 4 commits into from
Jul 22, 2022
Merged

[0.66] Flatlist keyboard navigation: Mouse can move selection #1269

merged 4 commits into from
Jul 22, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Backport of #1267

Saadnajmi and others added 2 commits July 19, 2022 15:27
@Saadnajmi @pull
@ryanlntn @ntre @mganandraj
Keyboard navigation in Flatlist (microsoft#1258)
c743549 
* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* [pull] master from microsoft:master (#11)

* Deprecated api (microsoft#853)

* Remove deprecated/unused context param
* Update a few Mac deprecated APIs

* Packing RN dependencies, hermes and ignoring javadoc failure,  (microsoft#852)

* Ignore javadoc failure

* Bringing few more changes from 0.63-stable

* Fixing a patch in engine selection

* Fixing a patch in nuget spec

* Fixing the output directory of nuget pack

* Packaging dependencies in the nuget

* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)

* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* fix mouse evetns on pressable

* delete extra yml from this branch

* Add macOS tags

* reorder props to have onMouseEnter/onMouseLeave always be before onPress

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>

* Grammar fixes. (microsoft#856)

Updates simple grammar issues.

Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Saad Najmi <[email protected]>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>

* wip

* wip

* more wip

* Home/End/OptionUp/OptionDown work

* ensureItemAtIndexIsVisible works

* Home/End work

* Initial cleanup for PR

* More cleanup

* More cleanup

* Make it a real prop

* No need for client code

* Don't move keyboard focus with selection

* Update tags

* Fix flow errors

* Update colors, make ScrollView focusable

* prettier

* undo change

* Fix flow errors

* Clean up code + handle page up/down with new prop

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>
@Saadnajmi @pull
@ryanlntn @ntre @mganandraj
Flatlist keyboard navigation: Mouse can move selection (microsoft#1267)
907998d 
* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* [pull] master from microsoft:master (#11)

* Deprecated api (microsoft#853)

* Remove deprecated/unused context param
* Update a few Mac deprecated APIs

* Packing RN dependencies, hermes and ignoring javadoc failure,  (microsoft#852)

* Ignore javadoc failure

* Bringing few more changes from 0.63-stable

* Fixing a patch in engine selection

* Fixing a patch in nuget spec

* Fixing the output directory of nuget pack

* Packaging dependencies in the nuget

* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)

* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* fix mouse evetns on pressable

* delete extra yml from this branch

* Add macOS tags

* reorder props to have onMouseEnter/onMouseLeave always be before onPress

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>

* Grammar fixes. (microsoft#856)

Updates simple grammar issues.

Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Saad Najmi <[email protected]>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>

* mouse selection works too

* remove pull.yml

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>
@Saadnajmi Saadnajmi requested a review from a team as a code owner July 22, 2022 00:08
Saadnajmi
Saadnajmi commented Jul 22, 2022
View reviewed changes
Libraries/Lists/FlatList.js Outdated
/**
* Move selection to the specified index
*
* @platform ios
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof this should have been macOS damnit

@pull-bot
Copy link

pull-bot commented Jul 22, 2022 •
edited
Loading

Fails
🚫

❔ This pull request needs a description.
Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 45f88a3

@Saadnajmi Saadnajmi merged commit 6496462 into microsoft:0.66-stable Jul 22, 2022
@Saadnajmi Saadnajmi deleted the list-with-mouse-66 branch July 22, 2022 19:16
chiuam added a commit that referenced this pull request Jul 29, 2022
@chiuam
Revert "[0.66] Flatlist keyboard navigation: Mouse can move selection (…
1c1efa8 
…#1269)"

This reverts commit 6496462.
@chiuam chiuam mentioned this pull request Jul 29, 2022
Merged
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
b767f8c 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 556cabcea962666b06098eb845ad414527a3fef0
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
5df47ea 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 9996f0b0d02759eb6e7afd8469d2317471162378
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
24a7475 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: e2c453e903c919dd9c6875208451295edc79a656
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 28, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
2a1dfd0 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: bdfbb4a3bc32bc005dbb639c5d7ab532ddd2c07a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 29, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
2ea0472 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 973984f8e9963a17cf9fefa5b024669ba9c6e9f7
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 29, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
b4c61c7 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: d4f7aae4c1758b514cbc84ed4fbc1c8ed6d0e62f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 29, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
96a16bc 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 2cc38bf8644bb31c7c98b0c208a58d63997e0e77
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 2, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
4fe6881 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 918747718cacd6d2dba8970f5aaf6e2db6ec623e
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 2, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
731425f 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 764517903b9b8ad1f55dded6d11d8388163f339e
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 2, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
4af113e 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 59af51541ee952c831a81e7f2a37d53f88e2c5c7
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 2, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
ab2b038 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 630791a0fec1e4842c876151e3de3d6bec7bb9b9
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 3, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
39433fc 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: c338c44f8ac94c39ea61d3a9c210fad5a239d52a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 3, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
809b5ac 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 30a23813bf756281d56b6078268194ba52fd3d4a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 3, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
ab73eab 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: a74f0b6e9bb575963c1af3d5adc513c53edc8d51
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 3, 2023
@NickGerleman @facebook-github-bot
Don't export private headers from Buck target (microsoft#1269)
ef57f4f 
Summary:
X-link: facebook/yoga#1269

Pull Request resolved: facebook#37127

This prevents targets which include Yoga from using its private APIs.

Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up.

Reviewed By: javache

Differential Revision: D45339425

fbshipit-source-id: 5b2fd84c6d1e23d32c31a1c5c59775a829b758fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amgleitman amgleitman amgleitman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saadnajmi @pull-bot @amgleitman