Don't depend on isFullKeyboardAccessEnabled for keyboard focus

[Saadnajmi]

Environment

n/a

Steps to reproduce the bug

Currently setting focusable on a View only works if you have a specific system preference enabled. This also blocks keyboard events (onKeyDown/onKeyUp) from happening. This is pretty unknown and slightly annoying. Let's fix this by simply removing the check on this line

react-native-macos/React/Views/RCTView.m

Line 1393 in 278d1b6

return ([self focusable] && [NSApp isFullKeyboardAccessEnabled]) || [super acceptsFirstResponder];

See https://microsoft.github.io/apple-ux-guide/KeyboardFocus.html

Expected Behavior

Keyboard events and keyboard focus work without having to know about the system preference.

Actual Behavior

Keyboard events and keyboard focus don't work at all without that preference.

Reproducible Demo

Go to the keyboard events page of RNTester.

Additional context

No response

[Saadnajmi]

I looked into this more, and it seems on apple platforms it's expected that not every control has keyboard focus by default. In general, only text input fields have keyboard access and you toggle the system preference "isFullKeyboardAccessEnabled" to add every other control with keyboard interaction to your key-view loop. As of iOS 13.4, this seems to be true on iOS as well, referring to this WWDC talk (Around timestamp 12:20): https://developer.apple.com/videos/play/wwdc2021/10120/.

So ideally , the React Native focusable prop would be more like an enum: [ .never, .withFullKeyboardAccess, .always] so that users could have better fine grained control over what has keyboard access in JS. That would be a breaking change, so we don't want to do that.

Instead, I think this would be an excellent topic to revisit if/when React Native Core adds keyboard support on iOS. It seems that iOS and macOS share similar API's and expectations around keyboard focus, so there's opportunity to share an API rather than have React Native macOS have it's own separate API.