take fix from meta/pristine

Author: Saadnajmi

packages/react-native/ReactCommon/react/renderer/components/view/platform/macos/react/renderer/components/view/HostPlatformViewEventEmitter.cpp

@@ -52,7 +52,8 @@ void HostPlatformViewEventEmitter::onKeyUp(const KeyEvent& keyEvent) const {
 
 #pragma mark - Mouse Events
 
-static jsi::Value mouseEventPayload(jsi::Runtime& runtime, const MouseEvent& event) {
+// Returns an Object instead of value as we read and modify it in dragEventPayload.
+static jsi::Object mouseEventPayload(jsi::Runtime& runtime, const MouseEvent& event) {
   auto payload = jsi::Object(runtime);
   payload.setProperty(runtime, "clientX", event.clientX);
   payload.setProperty(runtime, "clientY", event.clientY);
@@ -79,12 +80,14 @@ void HostPlatformViewEventEmitter::onMouseLeave(const MouseEvent& mouseEvent) co
 
 #pragma mark - Drag and Drop Events
 
-static jsi::Value dragEventPayload(jsi::Runtime& runtime, DragEvent const& event) {
-  auto filesArray = jsi::Array(runtime, event.dataTransferItems.size());
-  auto itemsArray = jsi::Array(runtime, event.dataTransferItems.size());
-  auto typesArray = jsi::Array(runtime, event.dataTransferItems.size());
+static jsi::Value dataTransferPayload(
+    jsi::Runtime& runtime,
+    const std::vector<DataTransferItem>& dataTransferItems) {
+  auto filesArray = jsi::Array(runtime, dataTransferItems.size());
+  auto itemsArray = jsi::Array(runtime, dataTransferItems.size());
+  auto typesArray = jsi::Array(runtime, dataTransferItems.size());
   int i = 0;
-  for (auto const &transferItem : event.dataTransferItems) {
+  for (const auto& transferItem : dataTransferItems) {
     auto fileObject = jsi::Object(runtime);
     fileObject.setProperty(runtime, "name", transferItem.name);
     fileObject.setProperty(runtime, "type", transferItem.type);
@@ -99,25 +102,33 @@ static jsi::Value dragEventPayload(jsi::Runtime& runtime, DragEvent const& event
       fileObject.setProperty(runtime, "height", *transferItem.height);
     }
     filesArray.setValueAtIndex(runtime, i, fileObject);
-    
+
     auto itemObject = jsi::Object(runtime);
     itemObject.setProperty(runtime, "kind", transferItem.kind);
     itemObject.setProperty(runtime, "type", transferItem.type);
     itemsArray.setValueAtIndex(runtime, i, itemObject);
-    
+
     typesArray.setValueAtIndex(runtime, i, transferItem.type);
     i++;
   }
-  
+
   auto dataTransferObject = jsi::Object(runtime);
   dataTransferObject.setProperty(runtime, "files", filesArray);
   dataTransferObject.setProperty(runtime, "items", itemsArray);
   dataTransferObject.setProperty(runtime, "types", typesArray);
 
+  return dataTransferObject;
+}
+
+static jsi::Value dragEventPayload(
+    jsi::Runtime& runtime,
+    const DragEvent& event) {
   auto payload = mouseEventPayload(runtime, event);
+  auto dataTransferObject =
+      dataTransferPayload(runtime, event.dataTransferItems);
   payload.setProperty(runtime, "dataTransfer", dataTransferObject);
   return payload;
-};
+}
 
 void HostPlatformViewEventEmitter::onDragEnter(DragEvent const& dragEvent) const {
   dispatchEvent("dragEnter", [dragEvent](jsi::Runtime &runtime) {
@@ -137,4 +148,4 @@ void HostPlatformViewEventEmitter::onDrop(DragEvent const& dragEvent) const {
   });
 }
 
-} // namespace facebook::react
+} // namespace facebook::react