Commit 18a6c74
fix(fabric, textinput): implement selection properly (#2689)
## Summary:
This is part of a series of PRs where we are cherry-picking fixes from
#2117 to update our
Fabric implementation on macOS.
This is furthermore, a subset of commits from #2675 . This set
specifically implements the text selection APIs on TextInput for macOS,
along with another set of commits to reduce our diffs in
`RCTCopyBackedTextInput`
## Test Plan:
Tested the TextInput selection examples in RNTester. All seem to work
well.
---------
Co-authored-by: Shawn Dempsey <[email protected]>
Co-authored-by: Nick Lefever <[email protected]>1 parent 1211612 commit 18a6c74
File tree
3 files changed
+25
-18
lines changed- packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput
3 files changed
+25
-18
lines changedLines changed: 21 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
679 | 679 | | |
680 | 680 | | |
681 | 681 | | |
682 | | - | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
683 | 687 | | |
684 | 688 | | |
685 | 689 | | |
| |||
835 | 839 | | |
836 | 840 | | |
837 | 841 | | |
838 | | - | |
839 | | - | |
| 842 | + | |
| 843 | + | |
840 | 844 | | |
841 | 845 | | |
842 | 846 | | |
| |||
862 | 866 | | |
863 | 867 | | |
864 | 868 | | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
865 | 872 | | |
866 | 873 | | |
| 874 | + | |
867 | 875 | | |
868 | 876 | | |
869 | 877 | | |
| |||
882 | 890 | | |
883 | 891 | | |
884 | 892 | | |
885 | | - | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
886 | 903 | | |
887 | 904 | | |
888 | 905 | | |
| |||
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 21 | + | |
| 22 | + | |
28 | 23 | | |
29 | 24 | | |
30 | 25 | | |
| |||
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 22 | + | |
| 23 | + | |
29 | 24 | | |
30 | 25 | | |
31 | 26 | | |
| |||
0 commit comments