Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate React Native CLI (RN v0.60.x) #1645

Closed
wants to merge 4 commits into from
Closed

Conversation

nineto4
Copy link

@nineto4 nineto4 commented Jul 28, 2019

@msftclas
Copy link

msftclas commented Jul 28, 2019

CLA assistant check
All CLA requirements met.

@congnguyen91
Copy link

+1 this should be checked :)

@v0lume
Copy link

v0lume commented Sep 17, 2019

can it be merged asap cause i don't want to see this errors anymore?

@aarongrider
Copy link

Bump on this!

@namvoeh
Copy link

namvoeh commented Oct 14, 2019

@nineto4 it's missing postlink and postunlink hooks, please check my PR #1699

@birkir
Copy link

birkir commented Oct 17, 2019

Cool, react-native-code-push is currently blocking RN 0.60 and 0.61 users from using the auto-linking feature.

@alexandergoncharov can you merge and release a new version?

@namvoeh
Copy link

namvoeh commented Oct 22, 2019

Please help to merge this 2 months old PR

Copy link
Author

@nineto4 nineto4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: alphabetical order

Copy link

@builtbyproxy builtbyproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to dismiss.
However, a lot of people are currently going through their node_modules to tweak specific things to their project. Could we use this chance to document what we are actually doing?

Including this link would be great: https://stackoverflow.com/questions/18641994/how-getresources-getstring-works-android

Also, if it was commands should it not still be commands? I thought only hooks translated to hooks

Thanks!

@giacomocerquone
Copy link

@builtbyproxy actually I believe that the use of prelink and postunlink "reserved" words in the commands object relies on a quite old rnpm version (in fact you can still find it in their locked repo https://github.com/rnpm/rnpm).
So it should be something that was already moved to the hooks object.

But I want to make clear that these are all assumptions and I couldn't find absolutely anything about how rnpm should be configured for a native lib. The only thing that drives me to that conclusion is the rnpm doc (showing an old commands-prelink/postlink configuration) and the migration guide (showing a prelink field inside the hooks object https://github.com/react-native-community/cli/blob/master/docs/configuration.md#libraries)

@builtbyproxy
Copy link

@giacomocerquone Absolutely Fantastic! Thanks a lot for explaining all of that!
Do you know what's blocking this merge?

@giacomocerquone
Copy link

@builtbyproxy the stale situation of this repo is blocking the merge.
I read comments of almost a year ago that the project went under a heavy modification process by the core team and I kept reading of people who's claiming that the project is not dead... yeah, probably, but surely I don't think this is the proper way to handle a migration. No public WIP board, no way we can help since the work is not being done through this repo... this doesn't look like OSS honestly 😅

To make people happy, it was as simple as declaring 1 or 2 trustable people that would have taken care of updating the docs, merging pull request of few lines like this etc. Etc.

Don't want to disrespect with this comment... we all rely on this package, and the devs did and I'm sure are still doing a great work, but just wanted to note this in order to handle the next "project rework" there might be a little bit better.

Honestly I'd like to help managing the issues and the pull requests, but no one would give me credit nor permission 😊

@bitlab-code
Copy link

Absolutely agree with what @giacomocerquone says
Without wishing to be pessimistic, everything suggests that Microsoft no longer has an interest in CodePush and React Native. Too much silence is probably "The beginning of the end", perhaps this "next version of CodePush" will be a new appcenter service

@giacomocerquone
Copy link

giacomocerquone commented Nov 13, 2019

Well @bitlab-code I wouldn't say that. React Native seems to be very important to Microsoft*, I just said that things could have done in a cleaner and more proper way, and actually like this is some sort of a disaster.

*https://www.theregister.co.uk/2019/11/07/microsoft_react_native/
*https://twitter.com/reactiflux/status/1184927584502665217

@builtbyproxy
Copy link

@giacomocerquone Who do we need to bug to get this stuff approved?
My patch-package for this is starting to get a bit overwhelming

@giacomocerquone
Copy link

Let's just ping the main contributors: @geof90 @lostintangent @max-mironov @alexandergoncharov the community needs you, I hope you won't be bothered by this request!
Thank you very much for consideration.

@joseph-d-p
Copy link

See PR #1735

@builtbyproxy
Copy link

Opened by a member of Microsoft :O

@alexandergoncharov-zz
Copy link
Contributor

Hi all,
Thanks for contributing and sorry for this big delay!

I think that it was fixed a long time ago by #1735.
So, I'm going to close this PR for now. Please feel free to reopen it if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.