-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate React Native CLI (RN v0.60.x) #1645
Conversation
+1 this should be checked :) |
can it be merged asap cause i don't want to see this errors anymore? |
Bump on this! |
Cool, @alexandergoncharov can you merge and release a new version? |
Please help to merge this 2 months old PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to dismiss.
However, a lot of people are currently going through their node_modules to tweak specific things to their project. Could we use this chance to document what we are actually doing?
Including this link would be great: https://stackoverflow.com/questions/18641994/how-getresources-getstring-works-android
Also, if it was commands should it not still be commands? I thought only hooks translated to hooks
Thanks!
@builtbyproxy actually I believe that the use of prelink and postunlink "reserved" words in the commands object relies on a quite old rnpm version (in fact you can still find it in their locked repo https://github.com/rnpm/rnpm). But I want to make clear that these are all assumptions and I couldn't find absolutely anything about how rnpm should be configured for a native lib. The only thing that drives me to that conclusion is the rnpm doc (showing an old commands-prelink/postlink configuration) and the migration guide (showing a prelink field inside the hooks object https://github.com/react-native-community/cli/blob/master/docs/configuration.md#libraries) |
@giacomocerquone Absolutely Fantastic! Thanks a lot for explaining all of that! |
@builtbyproxy the stale situation of this repo is blocking the merge. To make people happy, it was as simple as declaring 1 or 2 trustable people that would have taken care of updating the docs, merging pull request of few lines like this etc. Etc. Don't want to disrespect with this comment... we all rely on this package, and the devs did and I'm sure are still doing a great work, but just wanted to note this in order to handle the next "project rework" there might be a little bit better. Honestly I'd like to help managing the issues and the pull requests, but no one would give me credit nor permission 😊 |
Absolutely agree with what @giacomocerquone says |
Well @bitlab-code I wouldn't say that. React Native seems to be very important to Microsoft*, I just said that things could have done in a cleaner and more proper way, and actually like this is some sort of a disaster. *https://www.theregister.co.uk/2019/11/07/microsoft_react_native/ |
@giacomocerquone Who do we need to bug to get this stuff approved? |
Let's just ping the main contributors: @geof90 @lostintangent @max-mironov @alexandergoncharov the community needs you, I hope you won't be bothered by this request! |
See PR #1735 |
Opened by a member of Microsoft :O |
Hi all, I think that it was fixed a long time ago by #1735. |
Migrate React Native CLI
https://github.com/react-native-community/cli/blob/master/docs/configuration.md#migration-guide