Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onPinPressed vs. pinIsPressed #3509

Closed
mrpiay opened this issue Nov 19, 2017 · 4 comments
Closed

onPinPressed vs. pinIsPressed #3509

mrpiay opened this issue Nov 19, 2017 · 4 comments
Labels
bug P2

Comments

@mrpiay
Copy link

mrpiay commented Nov 19, 2017

I would suggest replacing "onPinPressed" by "onPinClicked" to avoid confusion. Thanks.

pressed
@samelhusseini
Copy link
Contributor

Related bugs:
#2495
#540

@abchatra
Copy link
Collaborator

@jpiay Good feedback. Though note we don't change API during the school year to keep it constant for the teachers (even if a API name is misnomer). We will definitely consider the change during the next major release of Micro:bit.

@mrpiay
Copy link
Author

mrpiay commented Nov 22, 2017

Thanks.

@mrpiay mrpiay closed this as completed Nov 22, 2017
@mrpiay mrpiay reopened this Nov 22, 2017
@mrpiay mrpiay closed this as completed Jan 29, 2018
@martinwork martinwork mentioned this issue Jul 26, 2018
Open
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abchatra @samelhusseini @mrpiay